summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix crash with popups over transparent backgrounds6.7Moss Heim2024-09-243-1/+26
| | | | | | | | | | | | | | An earlier color update fix (dcc464b14c) caused color updates to be applied to views without owner delegates, in the case of combo box popups for example. We now guard this pointer dereference. Fixes: QTBUG-128241 Pick-to: 6.7.3 Change-Id: Ib086c7d544b29bf41101ff423160de2310890174 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 9dae13cca7e06ea16db015aa35e61cc77e16951a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 12c02121d802b1314558afbf111153b55f121bca)
* Remove assert in RenderWidgetHostViewQt::WheelEventAckKaloyan Chehlarski2024-09-191-1/+2
| | | | | | | | | | | | | | | | When inspecting with devtools and using the screen cast option, attempting to scroll in the secondary view will cause the assertion to fail. This is because the WheelEventAck function gets called twice; once for the devtools view, and once for the full-size view. This change removes the assertion, and simply bails out of the function if no scroll event is pending. Change-Id: If4518c8be15ca0736756bb1e27a6de6c3d43d198 Reviewed-by: Anu Aliyas <anu.aliyas@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 23b8ff08a2b7ac753f8fc4829cf75f03bc87bb88) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 72adc4b55bcbb4a1596cd46225ea9bf8e66a016a)
* Correct documentation for QWebEngineUrlReuqestInfo::redirectMichael Brüning2024-09-191-1/+0
| | | | | | | | | | | | It was incorrectly stating the redirect did not work for requests with payload. Fixes: QTBUG-108763 Change-Id: If9bbbad9ac514fae811356c28aac586d8f24cd2f Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit bf159b2312640bb43d9ef180405baa7fb67d0bc7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 7a47e4017eca87f6ecbf4dfa766703f8746eaa3d)
* Stop location provider when location is disabled globallyKaloyan Chehlarski2024-09-191-1/+5
| | | | | | | | | | | | | | | | | | | | | Qt Core still doesn't have a permission backend on Windows, which results in the permission check for location always returning true, regardless of the actual Windows setting. In that case, the WebEngine location provider would just pass along the info that access was denied, but keep updates on, resulting in the location request just timing out. This change makes sure that the location provider is stopped immediately when access is denied, removing the timeout and signalling to the we application that permission has been denied. This isn't the exact behavior of other browsers, since they fall back on consentless (low accuracy) location info and we don't, but that's a limitation of the QtPositioning module. Change-Id: I097bade1ec6b31352321139195b630124657c23a Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit ba1d8dc18f6b2406f39968ec1070ea5becfb6a8e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit fdc60518c5c41efdac80a45d8385a0d235204941)
* Do not create shared OpenGL context when D3D11 RHI is usedVladimir Belyavsky2024-09-151-32/+39
| | | | | | | | | | | | | | We don't need shared OpenGL context when D3D11 RHI is used on Windows. So we shouldn't even try to create it, otherwise we might encounter unexpected side effects like warnings or even crashes when creating OpenGL context on some older GPUs/drivers. Fixes: QTBUG-128784 Change-Id: I8f7a6dd7c5dd56c361a085c45fffb8dcfcfb722f Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 7eeabd5a0103f7dde66814d6e49806a2f2a1cc20) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 3d8b9b4860e3d5ea44cb97ae82cc32283a9cd1df)
* EGL: Do not create GL context with no compatible surfaceVladimir Belyavsky2024-09-151-0/+4
| | | | | | | | | | | | | | Otherwise it crashes on gl::GLContextEGL::Initialize() with nullptr access. It is not yet clear under what conditions we cannot create a compatible surface, but it may somehow happen on some older AMD GPUs. Task-number: QTBUG-128308 Change-Id: I24845c4a6785872f1b3ff56adacaa2a6cef0e5f7 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 5bd9d6183dcbad1e7fb9ac83a79217a9ee16b865) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit cd6dc906fd95de2ca8c00d7ffe03e933ebb27e94)
* Fixup pinch gesture event handlingAnu Aliyas2024-09-142-0/+3
| | | | | | | | | | | | | | | | | | | | The current gesture pinch event handling requires the needs_wheel_event to be set. When the gesture event is created, it is set to true, so that the input router knows to offer the event to the renderer as a wheel event. Once the wheel event is acknowledged, needs_wheel_event is set to false and the event is resent. When the input router receives it the second time, it knows to send the real gesture event to the renderer. Qt webengine creates pinch begin and end events with needs_wheel_event set to true, but the same is missing for update event. The event resent logic is also missing. This can be done from RenderWidgetHostViewQt::GestureEventAck() by calling ForwardTouchpadZoomEventIfNecessary(). Change-Id: I52da137c69da494f497bcd112fcdd466eb08281b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 0dcf9312f9a5cfa87d0392a5c4ddc2d0ebec775e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 2de0ca74cdeb98718a5cafbb76357ced0d107dd1)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-09-061-4/+4
| | | | | Change-Id: I59830a4d456b0a586e60f7c4a0da54ecec04c010 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-09-051-4/+4
| | | | | Change-Id: I6c21c96b6578c48a3bfeb1978788431c6e27a272 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-08-291-4/+4
| | | | | Change-Id: I5ceb7411fab10af02683ec139ecca9a3a3e0117b Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Quick Nano Browser: Remove usage of QCommandLineParserKaloyan Chehlarski2024-08-291-13/+11
| | | | | | | | | | | | | This change partially reverts 98bae072c090ee19e2a5a1e85eed712a060d12fc to remove usage of QCommandLineParser. The class does not support WebEngine's way of passing arguments to Chromium using --webEngineArgs, and attempting to do so simply closes the app at startup. Pick-to: 6.5 Change-Id: I7a26637da8771aaa1851bc988118acd074e00997 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit c3a8bb64eab796ae997d7447c596c54f83264265) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix not working popup with qquick on eglfsMichal Klocek2024-08-291-2/+3
| | | | | | | | | | | | | After refactoring in 5d1ef38 we lost popups with qquick. Unfortunately we do not have tests for it as we do not run eglfs on ci. Fixes: QTBUG-119908 Change-Id: Iea6cadf96dcac488898bb31132938fe8020d4d79 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 746cdfc088eaf4171d8dc1dc0ae489cdd846c68a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 6d65c33cd660e5b92df15c7785fe0f9bf54c0547)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-08-271-4/+4
| | | | | Change-Id: Ibbc8beaa2d3e731f4cb137e4c7dc45e9c63e44c6 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Disable blink WebOTP featureAnu Aliyas2024-08-271-0/+1
| | | | | | | | | | | | | | Qt webengine doesn't support WebOTP and the feature is disabled by webengine. runtime feature enable option is marked as kSetOnlyIfOverridden for WebOTP, due to which blink feature is not affected by base::Feature and explicit disabling of blink feature is need in such cases. Fixes: QTBUG-126256 Change-Id: Ifedbc8d20aa6930cd5dcb3ea750d01cabfc99481 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 9839a94ca77992077272a1988b387a26a6e3f637) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 408c7588fd343332cd7bf4c4676ea1359aba72e2)
* fix conditional redundancy for receivedBytesTian Shilin2024-08-271-1/+5
| | | | | | | | | | | | | | In updateWidget,receivedBytes / m_timeAdded.elapsed() * 1000 may divide by zero,if m_timeAdded.elapsed() returns 0, it will cause the denominator in the division to be zero, which will trigger a warning or error, to fix this, check the m_timeAdded.elapsed() is zero, if it is, you can set a default value () or just set bytesPerSecond to 0 to avoid dividing by zero. Change-Id: Id73b287d44241f97271308f85c64d4830b944948 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit f57db4b9a4c71133b781773c2e6e6d5121de4fe7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit f2cc6aa0ef438aa8b7ab5ae8eaeb38d99e6bb852)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-08-261-4/+4
| | | | | Change-Id: I0b4e387384bb58c18a4149b21878f7344b133331 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Document sourceUrl() and setSourceUrl() in QWebEngineScriptAnu Aliyas2024-08-241-1/+15
| | | | | | | | | | | | Added missing documentation for sourceUrl and setSourceUrl in QWebEngineScript. Fixes: QTBUG-128140 Change-Id: Iff77961060a8b3efea42d074ac66c4800afc0fb3 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit e013c508e99b74866a480a52d6a23aeda0473b4b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 52455440635a2cc9beb6a5e667fe78f21963030e)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-08-221-4/+4
| | | | | Change-Id: I3c650667ef4abb5346801713edbadd13066c6dd4 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Hook up quicknanobrowser to screen capturing APIKaloyan Chehlarski2024-08-221-0/+6
| | | | | | | | | | | | A Qt Quick API was implemented alongside the Widgets one, but it seems the quicknanobrowser example was never updated to make use of it. Change-Id: I8ac996f2237a2673bdbbab85a8174fa166fdd5b1 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 0d9e429b4de070eaac5d5508832f22efdcdf633f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit c407b198b7f8a42ad639d04be5d11cef3e7e6c7b) Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
* fix: Avoid empty engineTian Shilin2024-08-201-2/+4
| | | | | | | | | | | | | | | | | | | | The engine variable is obtained by calling qmlEngine(m_view). If m_view is not associated with a valid QML engine, then the engine may be null,so advancing the null check on the engine to immediately after the engine is fetched ensures that an invalid engine is not accidentally used in subsequent code, especially if(m_importDirs.isEmpty() && !initializeImportDirs(m_importDirs, engine)),which I verified with a static scan tool to verify the above statement,and found that it does indeed result in a nullpointer error of type Change-Id: I8cc427d2b94f93e8c9fc24a202d41abd8e00143d Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit b13a99a01e950bfd471f5ade8455dade2504fe6b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 1dba5a2a42f75db182081f1e48ea35759bb7d62a)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-08-201-4/+4
| | | | | Change-Id: Iea18c2c426bd93011d739e26dc57541601e53772 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* fix conditional redundancy for totalBytesTian Shilin2024-08-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | m_progressBar->setValue(qRound(100 * receivedBytes / totalBytes)); There is a potential risk of de-zeroing here, since receivedBytes / totalBytes will trigger a runtime error if totalBytes is zero. In addition, if totalBytes is always greater than or equal to 0, then checking for totalBytes >= 0 is actually redundant, since the concern should be that totalBytes is not zero. To ensure the robustness of the code, a check that totalBytes is zero should be added to prevent divide-by-zero errors. By ensuring that totalBytes is greater than zero, this improvement not only avoids the risk of de-zeroing, but also ensures that the percentage calculation of the progress bar is meaningful. At the same time, for cases where totalBytes is 0 or unknown, the progress bar is displayed as 0% and the format is "unknown size". This is a safer way to handle the situation and is more in line with the needs of the actual application. Change-Id: I7537243e375f336f5c68ef1cc6ec8ade8fa16e5c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 16aa88039199e6ffbed95818fb9366db8f47aecf) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 5fff4a3a9507c741e2dc5918e08a3be54bf6a0d4)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-08-151-4/+4
| | | | | Change-Id: Ia76ecee2f20f7f4c00013de8b470842b9faa0713 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update ChromiumMichael Brüning2024-08-153-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 09a04a46..de88aea7: * FIXUP: "Shut GL down on process exit to silence Direct3D11 warnings * [Backport] Security bug 340895241 (2/2) * [Backport] Security bug 340895241 (1/2) * Shut GL down on process exit to silence Direct3D11 warnings * [Backport] CVE-2024-7532: Out of bounds memory access in ANGLE (2/2) * [Backport] CVE-2024-7532: Out of bounds memory access in ANGLE (1/2) * [Backport] CVE-2024-7550: Type Confusion in V8 * [Backport] CVE-2024-7536: Use after free in WebAudio * [Backport] Dependency for CVE-2024-7536 * [Backport] CVE-2024-7535: Inappropriate implementation in V8 * [Backport] CVE-2024-6996: Race in Frames * [Backport] Security bugs 40063014 and 40068800 * [Backport] Security bug 333453962 * [Backport] Security bug 341640868 * [Backport] CVE-2024-7000: Use after free in CSS * [Backport] CVE-2024-6999: Inappropriate implementation in FedCM * [Backport] CVE-2024-6992: Out of bounds memory access in ANGLE * [Backport] CVE-2024-6992: Out of bounds memory access in ANGLE * [Backport] CVE-2024-6991: Use after free in Dawn * [Backport] CVE-2024-6989: Use after free in Loader * [Backport] CVE-2024-6779: Out of bounds memory access in V8 * [Backport] CVE-2024-6777: Use after free in Navigation * [Backport] CVE-2024-6774: Use after free in Screen Capture * [Backport] CVE-2024-6101: Inappropriate implementation in WebAssembly * [Backport] CVE-2024-6103: Use after free in Dawn * [Backport] CVE-2024-5836: Inappropriate Implementation in DevTools (3/3) * [Backport] CVE-2024-5836: Inappropriate Implementation in DevTools (2/3) * [Backport] CVE-2024-5836: Inappropriate Implementation in DevTools (1/3) * [Backport] Security bug 336214779 * [Backport] Security bug 346197738 * [Backport] CVE-2024-6291: Use after free in Swiftshader * [Backport] CVE-2024-6293: Use after free in Dawn * [Backport] CVE-2024-6292: Use after free in Dawn * [Backport] CVE-2024-6290: Use after free in Dawn * [Backport] CVE-2024-5840: Policy Bypass in CORS * [Backport] CVE-2024-5841: Use after free in V8 * [Backport] CVE-2024-5845: Use after free in Audio * [Backport] CVE-2024-5847: Use after free in PDFium * [Backport] CVE-2024-5846: Use after free in PDFium * [Backport] CVE-2024-5831: Use after free in Dawn (2/2) * [Backport] CVE-2024-5831: Use after free in Dawn (1/2) * [Backport] CVE-2024-5832: Use after free in Dawn * Work around MSVC 17.10 bug * Modify .gitattributes to stop PDF file line ending changes * Suppress DCHECK triggered by function RecordHadPreviousSyncAccount * Remove use of dawn_version_file * Fix missing <string> include * ANGLE: Silence private data warnings when using Direct3D11 backing * [Backport] CVE-2024-5493: Heap buffer overflow in WebRTC * [Backport] Security bug 339736513 * [Backport] Security bug 340606786 * [Backport] CVE-2024-5494: Use after free in Dawn * [Backport] CVE-2024-5495: Use after free in Dawn * [Backport] CVE-2024-5496: Use after free in Media Session * [Backport] CVE-2024-5499: Out of bounds write in Streams API * [Backport] CVE-2024-5274: Type Confusion in V8 * [Backport] CVE-2024-4948: Use after free in Dawn. * [Backport] Security bug 329693878 * [Backport] Security bug 329699609 * [Backport] Security bug 338574384 * thread_restrictions: Add PermissionManagerQt as friend class * [Backport] Security bug 340221135 Fixes: QTBUG-127160 Fixes: QTBUG-127886 Fixes: QTBUG-127887 Fixes: QTBUG-127888 Fixes: QTBUG-127890 Fixes: QTBUG-127891 Task-number: QTBUG-123790 Change-Id: Ica94ad7f27d4d2abbb597ece61c508dd3adb2367 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Document Microsoft CRT version runtime requirementMichael Brüning2024-08-131-0/+2
| | | | | | | | | | Pick-to: 6.5 Fixes: QTBUG-125300 Change-Id: Idd9e61b7d081c09e32f44b79c9e49ead982acbc7 Reviewed-by: Oliver Wolff <oliver.wolff@qt.io> (cherry picked from commit 112efa88b70a1503fe781035e07e96f5af913539) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit b282e4b03709dbfc3b4abab722173fc51d8579e1)
* Do not use system re2 by defaultAllan Sandfeld Jensen2024-08-131-0/+1
| | | | | | | | | | | | It is now more likely to be incompatible than compatible. Fixes: QTBUG-124274 Change-Id: Id0d257afc8964dd7ec7bce2f059b91dfd6391197 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Moss Heim <moss.heim@qt.io> (cherry picked from commit dcd7664ab873b6476de1bb6cfcb5043fba9aaf3c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 26bf8a6561e26345307fde23a74a63a289530ad5)
* Mention need for --webEngineArgs also in command line options sectionMichael Brüning2024-08-121-0/+8
| | | | | | | | | | | | We are referring to the command line options section from other sections, so it makes sense to mention the need to use --webEngineArgs there. Pick-to: 6.5 Fixes: QTBUG-124878 Change-Id: I600bfcd8cf2d8aada53b883608e2a10ea932bdc2 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 4f2c8c194b535b54b1cba0f0f0e47a9f9e707cf2) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit b6d619ef94566f74baa33d8514bf54819c63b839)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-08-061-4/+4
| | | | | Change-Id: Ia7f8e30417ae0db36ecd7425afa341c23d4585a9 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-08-021-4/+4
| | | | | Change-Id: Ie7417bf98b919bd7259948375b1f92434c876c64 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-08-011-4/+4
| | | | | Change-Id: I9c10c22cbbf1018bb1d5d206af9f53e901631953 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-07-311-4/+4
| | | | | Change-Id: I4e4eb99e0a8be42a95e6df3e859b6e7c437a5a42 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Workaround for setCursor issue with embedded viewsMartin Negyokru2024-07-305-0/+72
| | | | | | | | | | | | | | | | | | | | | QQuickItem::setCursor maps the cursor position to the window while the Item's position is mapped to the View. If the View is moved inside its container, the offset is ignored on the Item. Ergo View.pos != Item.pos breaking hittesting of setCursor. Fix this by forwarding Item::setCursor calls to the View. It is safe since the Item shares its coordinate system with chromium and works as a proxy to the View. Fixes: QTBUG-111927 Fixes: QTBUG-123889 Fixes: QTBUG-115929 Pick-to: 6.6 Change-Id: Idee5ba043774952b554874ce654279cb5029ef1d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 5043f4ddff206d2ffcb4684fb791ec689c2538f0) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 76b5ab01a93c64f8644b2e0bf2c6f0ead939c05e)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-07-251-4/+4
| | | | | Change-Id: Ifbf2bba7902b51df28d238a4f995eeaad127feb4 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Find text: Start new search when toggling case sensitivityKaloyan Chehlarski2024-07-244-1/+42
| | | | | | | | | | | | | | | Only toggling case sensitivity, without changing the text that's being looked up, would keep the helper in "find next" state, which in turn would keep otherwise invalid matches highlighted on screen. This change ensures that a new text search is initiated in cases like this. Fixes: QTBUG-127318 Change-Id: I95b410b123dc09851f5aaefc8470f0656a88bb0d Reviewed-by: Anu Aliyas <anu.aliyas@qt.io> (cherry picked from commit 7f47a253ba7bce2d76f41079c34bc9468ec142aa) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit e23a577e15e72fc57b3972f8311ee43988429cf6)
* Partially stabilize QML favicon testsKaloyan Chehlarski2024-07-232-15/+7
| | | | | | | | | | | | | | | | | It seems that the pattern... 1. trigger action 2. start wait()-ing on a signal spy 3. continue after the signal is received ...is somewhat cursed in QML, since the signal may trigger inbetween steps 1 and 2, which will cause the wait() to never return true. This change removes that pattern from the favicon tests, which will hopefully reduce the tests' flakiness. Change-Id: I65cd3b8c8ae5fc855138eec94821eb932d999c3b Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 7cdcdb10915455c8ccb7f470158de0cc2fe66223) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit d8cb9ae856e4fb03bc1f1dc0b7c65d4bc5187faa)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-07-181-4/+4
| | | | | Change-Id: Id9cce4c6c92fb9eb79843f6246f3908608ead471 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Remove usage of non-standard swprintfKaloyan Chehlarski2024-07-151-1/+1
| | | | | | | | | | | | | WebEngineLibraryInfo::isRemoteDrivePath usea an MSVC-only, non-standard version of swprintf which doesn't have a len argument, triggering a compiler warning. This change adds the len argument, which fixes the warning. Change-Id: I7124e5e5260ed39e46f7df4dc4dfc39521d6374d Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit f4b3399471112ae5f6df86c649df2c6e25c99410) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit d4435b47ada2d2f14e980c30d390b9a99dff80f5)
* Add more vendors to GPU detectionKaloyan Chehlarski2024-07-151-7/+35
| | | | | | | | | | | | | | | This change expands the list of GPU vendors in the web engine context creation code. The original list was based on code inside Dawn, whereas this change adds entries from an equivalent list in ANGLE. This removes some startup warnings for a few more exotic system configurations (e.g. VMWare virtual machines). Fixes: QTBUG-126722 Change-Id: I5548cc0677f80e02439e7c4cfc3ab1d680d10971 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 791ee8106f7a6c8f9c0bf13a46721df2a6cde651) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 83e85bebcb5257a29402b6d4f64925b63ac3d3a1)
* Add a licenseRule.json file for checking of SPDX license identifiersLucie Gérard2024-07-111-0/+104
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The license test in qtqa reads this file in order to check the validity of the license used. This file reproduce the QUIP-18 [1] rules, with some exceptions. Each entry in the file corresponds to a set of licensing rules. A set of licensing rules can depend on the file ending, registered in "file_pattern_ending". The last entry in the file has no "file_pattern_ending", it sets the rules for the files whose licensing does not depend on their ending. The license to be used depends on the location of the file within the Qt module repository. Let's call this "<true_location>". The "<true_location>" can also correspond to a file name, offering flexibility for exceptions to the rule. The "<true_location>" are registered in "location". For each "<true_location>" there is a "file type" entry and a "spdx" entry. The "spdx" entry gives the rule: the expected license tag(s) in SPDX format for the file ending (if applicable) and "<true_location>". The "file type" informs on the QUIP-18 type the tested file corresponds to. It is purely informational for the reader. The set of rules are tested in order of appearance in the json file. For this reason, a more constraining ending (like "special.txt") needs to appear in a "file_pattern_ending" located before the "file_pattern_ending" of a less constraining ending (like ".txt"). Also, a file ending cannot be present in two "file_pattern_ending". "file_pattern_ending" and "spdx" should list strings. "<true_location>" can be regular expressions. During the test the deeper "<true_location>" are checked first. The order is which they appear in the json file does not matter. To test this file, run QT_MODULE_TO_TEST=../qtwebengine perl tests/prebuild/license/tst_licenses.pl [1]: https://contribute.qt-project.org/quips/18 Task-number: QTBUG-121039 Change-Id: I4c6c5a78ca17e3afb20023e7339b1b6caf04be83 Reviewed-by: Kai Köhne <kai.koehne@qt.io> (cherry picked from commit 5693d073d1478967362d8f81f29b7f57ba88da66) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 5313ab65edb681571175c03114b479a32474d3c8)
* Correct license for module and plugin filesLucie Gérard2024-07-094-4/+4
| | | | | | | | | | | | | Those files partially come from Chromium and are made available only under BSD-3-Clause Task-number: QTBUG-121787 Change-Id: Iba17543d385f157a648959dcd2b46eaf0e43a7f1 Reviewed-by: Kai Köhne <kai.koehne@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit e8f074f3c318b7ececb02e6ed5ba34a869327f40) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 686eb71d22529f170715822af1c95c4cea3e9fd9)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-07-081-4/+4
| | | | | Change-Id: Ie64cf3d72e975b0c8f95539e7f4a345daedb7a1b Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Replace urn:dje license identifier with SPDX compatible oneKai Köhne2024-07-083-4/+3
| | | | | | | | | | | | | | We aim for using only valid SPDX expressions in LicenseId fields. But SPDX does not contain a generic 'Public Domain' license, which is why we were going for urn.dje licenses originally. Anyhow, best practice is to use custom LicenseRef- licenses in this case. Task-number: QTBUG-126403 Change-Id: I1d050ae42603168c6a4c9d44eeb7fdd6767af060 Reviewed-by: Lucie Gerard <lucie.gerard@qt.io> (cherry picked from commit 8e22839aa06bed928e37bf9172ee7b31fc2b7ee1) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit c6fa99b96028817d657a793e9f0cc8220b778078)
* Replace urn:dje license identifier IIKai Köhne2024-07-081-2/+1
| | | | | | | | | | | Amends 8e22839aa0 Task-number: QTBUG-126403 Change-Id: I1560e5af29d2e94657a83e98bb649729b4a67cd2 Reviewed-by: Lucie Gerard <lucie.gerard@qt.io> (cherry picked from commit 994986fb96044551b5c43523a3589e989c2b2294) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit d8d0aeb17e892b049d8b876c9dc911f7e48afe0e)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-07-051-4/+4
| | | | | Change-Id: I7c6a11868792618f3f83ca8a22bd0331abb1f266 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Add missing dependencies to webengine devtools source setAnu Aliyas2024-07-041-0/+1
| | | | | | | | | | | | Missing dependencies are added to resolve the dependencies issues encountered when compiling with Ninja 1.12.0 Fixes: QTBUG-125035 Change-Id: Ia089f407852efdeb837c6fc348e9d1fbb43a0da7 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 35f49e787dd5894c0f890855b1ac2f0d7c24421d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 9603e7f5aee70ebfa2ef96e35b809e43b79f070b)
* Correct license for documentation fileLucie Gérard2024-07-021-1/+1
| | | | | | | | | | | | | | According to QUIP-18 [1], all documentation files should be LicenseRef-Qt-Commercial OR GFDL-1.3-no-invariants-only [1]: https://contribute.qt-project.org/quips/18 Task-number: QTBUG-121787 Change-Id: Ibf7b2738d62e5f2075183d2f0376774583595a55 Reviewed-by: Kai Köhne <kai.koehne@qt.io> (cherry picked from commit 86e97f65b6afc495ddf46f4b39eac47646e83b0a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 55942cfb6b2306234c8278a70413ec827180ad08)
* Ensure deferred deletion of WebEngineQuickWidgetMartin Negyokru2024-07-012-0/+20
| | | | | | | | | | | | | | | In some cases the event loop exits before WebEngineQuickWidget::deletLater is called. In this scenario the object will not be deleted. Fixes: QTBUG-126401 Pick-to: 6.6 Change-Id: I9de8640c6f8d3b0f04665bce664f8b91523ddb69 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Anu Aliyas <anu.aliyas@qt.io> (cherry picked from commit a9357c72535b5e99f75b03af560badbb90dfa6f1) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 1eb8f906a5bb0cb3ed12ff8d65d595ac46b1fced)
* Correct license for test filesLucie Gérard2024-06-28153-153/+153
| | | | | | | | | | | | | | | According to QUIP-18 [1], all test files should be LicenseRef-Qt-Commercial OR GPL-3.0-only [1]: https://contribute.qt-project.org/quips/18 Task-number: QTBUG-121787 Change-Id: I7ba480e5d9b9095ad6686c8b1c857f35caf17d04 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kai Köhne <kai.koehne@qt.io> (cherry picked from commit a2d4c8a183e763b097e16f52172092cdb627b731) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit bcfb37c93850ae4bfc189d6d48835f4467e90159)
* Update dependencies on '6.7' in qt/qtwebengineQt Submodule Update Bot2024-06-271-4/+4
| | | | | Change-Id: Ic574a7652779b49bad92a90c7502787bec5cee8f Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Docs: fix the QML docs for the PdfSelection::text propertyAlexei Cazacov2024-06-272-3/+8
| | | | | | | | | | | | | | | | The QML docs described the "string" property, but the actual property name is "text". Add a selectAll() shortcut to the withdoc.qml manual test while we're at it, for easier checking of behavior. Fixes: QTBUG-126138 Pick-to: 6.5 6.2 Change-Id: Ieab6188661d4e9b1c1f4dc4faaf355b94bdc3f4c Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 1caa4fd26b25d97507e916780e34e70720ceb0b2) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 7338266ed2fc40941deef18f3c5c04d27699f695)
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-21 17:42:59 +0000