Fix some inconsistencies with memory freeing in pg_createsubscriber
authorMichael Paquier <michael@paquier.xyz>
Wed, 12 Feb 2025 08:11:47 +0000 (17:11 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 12 Feb 2025 08:11:47 +0000 (17:11 +0900)
commitff6d9cfcb17e48c313aefe8fc65cdaeacd8766bf
tree681e7d27c6937b9d06971327a9cc488d4bb90ca6
parentfa761d9c71375ec49234c77cc1951394ffac6fe1
Fix some inconsistencies with memory freeing in pg_createsubscriber

The correct function documented to free the memory allocated for the
result returned by PQescapeIdentifier() and PQescapeLiteral() is
PQfreemem().  pg_createsubscriber.c relied on pg_free() instead, which
is not incorrect as both do a free() internally, but inconsistent with
the documentation.

While on it, this commit fixes a small memory leak introduced by
4867f8a555ce, as the code of pg_createsubscriber makes this effort.

Author: Ranier Vilela
Reviewed-by: Euler Taveira
Discussion: https://postgr.es/m/CAEudQAp=AW5dJXrGLbC_aZg_9nOo=42W7uLDRONFQE-gcgnkgQ@mail.gmail.com
Backpatch-through: 17
src/bin/pg_basebackup/pg_createsubscriber.c