Merge pull request cheran-senthil#98 from cheran-senthil/fix/pollard-rho

Vary f to not hang on 124376107291

Author: Mukundan314

pyrival/algebra/factors.py

@@ -40,11 +40,11 @@ def pollard_rho(n):
                 break
         else:
             for i in range(2, n):
-                x, y = i, (i * i + 1) % n
+                x, y = i, (i * i + i) % n
                 f = gcd(abs(x - y), n)
                 while f == 1:
-                    x, y = (x * x + 1) % n, (y * y + 1) % n
-                    y = (y * y + 1) % n
+                    x, y = (x * x + i) % n, (y * y + i) % n
+                    y = (y * y + i) % n
                     f = gcd(abs(x - y), n)
                 if f != n:
                     return f

pyrival/algebra/primitive_root.py

@@ -40,11 +40,11 @@ def pollard_rho(n):
                 break
         else:
             for i in range(2, n):
-                x, y = i, (i * i + 1) % n
+                x, y = i, (i * i + i) % n
                 f = gcd(abs(x - y), n)
                 while f == 1:
-                    x, y = (x * x + 1) % n, (y * y + 1) % n
-                    y = (y * y + 1) % n
+                    x, y = (x * x + i) % n, (y * y + i) % n
+                    y = (y * y + i) % n
                     f = gcd(abs(x - y), n)
                 if f != n:
                     return f