Skip to content

Calendar View of Meetups #24 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from

Conversation

itsevalieu
Copy link
Member

Create week view for meetups and toggle functionality between list view and week view. Will need some refactoring for sure.

@LearningNerd
Copy link
Member

This is awesome!! :) Thank you @itsevalieu ! A couple thoughts:

  • Maybe we should add written labels for the two different views instead of only icons: "list view" and "week view"?

  • I actually think the week view would be better as the default! What do you think @jbazalar ?

@jbazalar
Copy link
Collaborator

jbazalar commented Apr 8, 2019

Looks like you've been moving along with this @itsevalieu ! Looking foward to reviewing this with you tomorrow at meetup.

@LearningNerd I haven't had a chance to review this version just yet (just got back from a conference long week/end), but as you saw, we'll be review with Eva tomorrow. I figured that might be a good time to get some feedback from other members regarding which view they might prefer as a default.

@itsevalieu
Copy link
Member Author

itsevalieu commented Apr 17, 2019

Hi! I can totally change the icons to written labels, and add state to it like @jbazalar has told me it doesn't have haha. I also need to make a pull request for my calendarview branch, not master. Oops! I'm not sure if I can change the branch I want to make a pull request here, so I'll close this one and make another.

@itsevalieu itsevalieu closed this Apr 17, 2019
@itsevalieu
Copy link
Member Author

Making pull request for calendarview instead of master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants