-
Notifications
You must be signed in to change notification settings - Fork 9
Comparing changes
Open a pull request
base repository: MattDMo/PythonImproved
base: master
head repository: MattDMo/PythonImproved
compare: fichtefoll_changes
- 13 commits
- 3 files changed
- 2 contributors
Commits on Sep 3, 2014
-
Built-in functions are now only matched by ident
Essentially reverts #8, but this is in scope of a bigger change. Also clearly separate built-in functions and built-in types because some used to be duplicated.
Configuration menu - View commit details
-
Copy full SHA for 3ae9d47 - Browse repository at this point
Copy the full SHA 3ae9d47View commit details -
Properly match ident patterns inside function call
The previous attempt just didn't work because of two reasons: 1. The "dotted_name" was already consumed in function-call's "begin" match. 2. All "special" identifiers were essentially matched before the function call which meant that the actual call would never be matched since the function to be called (the identifier) was already consumed. Simplify #dotted_name a bit in the process.
Configuration menu - View commit details
-
Copy full SHA for 6bd2fc2 - Browse repository at this point
Copy the full SHA 6bd2fc2View commit details -
Re-add print and del statement matching
The print statement can now only be matched if it's not used in a function previously since otherwise it would've been consumed.
Configuration menu - View commit details
-
Copy full SHA for 828ab43 - Browse repository at this point
Copy the full SHA 828ab43View commit details -
Configuration menu - View commit details
-
Copy full SHA for b847ef4 - Browse repository at this point
Copy the full SHA b847ef4View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf5b349 - Browse repository at this point
Copy the full SHA cf5b349View commit details
Commits on Sep 4, 2014
-
Fix indent of decorators being highlighted
Although it looked okay-ish with background color it was not intended.
Configuration menu - View commit details
-
Copy full SHA for 3ea8cb8 - Browse repository at this point
Copy the full SHA 3ea8cb8View commit details -
dotted_name should not include linebreaks
Otherwise, color schemes defining a background color for `entitiy.name.function` would make decorators span the remainder of the line.
Configuration menu - View commit details
-
Copy full SHA for 42bb653 - Browse repository at this point
Copy the full SHA 42bb653View commit details
Commits on Oct 1, 2014
-
Match ALL_CAPS constants in dotted names
Previously, `self.CONSTANT` was not matched.
Configuration menu - View commit details
-
Copy full SHA for 61479aa - Browse repository at this point
Copy the full SHA 61479aaView commit details -
print
must be an ident if followed by,
Or well, it's only valid syntax in Python 3.
Configuration menu - View commit details
-
Copy full SHA for 17ea9f5 - Browse repository at this point
Copy the full SHA 17ea9f5View commit details -
Dotted names may span multiple lines
Even though we can't really match that correctly, at least match the leading dot on a new line or after a function call. That's more correct. Example: ident = (value.dotted .__init__)
Configuration menu - View commit details
-
Copy full SHA for ee007cb - Browse repository at this point
Copy the full SHA ee007cbView commit details -
It could be of use for regression testing later, or whatever. In any case it should illustrate most of the changes of my pull request and can easily be extended.
Configuration menu - View commit details
-
Copy full SHA for c9ad654 - Browse repository at this point
Copy the full SHA c9ad654View commit details
Commits on Nov 15, 2014
-
Configuration menu - View commit details
-
Copy full SHA for b29c10d - Browse repository at this point
Copy the full SHA b29c10dView commit details -
Merge pull request #22 from FichteFoll/better_function_match
Better function match
Matt Morrison committedNov 15, 2014 Configuration menu - View commit details
-
Copy full SHA for c481441 - Browse repository at this point
Copy the full SHA c481441View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...fichtefoll_changes