Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MattDMo/PythonImproved
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: MattDMo/PythonImproved
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fichtefoll_changes
Choose a head ref
  • 13 commits
  • 3 files changed
  • 2 contributors

Commits on Sep 3, 2014

  1. Built-in functions are now only matched by ident

    Essentially reverts #8, but this is in scope of a bigger change.
    
    Also clearly separate built-in functions and built-in types because some
    used to be duplicated.
    FichteFoll committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    3ae9d47 View commit details
    Browse the repository at this point in the history
  2. Properly match ident patterns inside function call

    The previous attempt just didn't work because of two reasons:
    1. The "dotted_name" was already consumed in function-call's "begin"
       match.
    2. All "special" identifiers were essentially matched before the
       function call which meant that the actual call would never be
       matched since the function to be called (the identifier) was already
       consumed.
    
    Simplify #dotted_name a bit in the process.
    FichteFoll committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    6bd2fc2 View commit details
    Browse the repository at this point in the history
  3. Re-add print and del statement matching

    The print statement can now only be matched if it's not used in a
    function previously since otherwise it would've been consumed.
    FichteFoll committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    828ab43 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b847ef4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cf5b349 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2014

  1. Fix indent of decorators being highlighted

    Although it looked okay-ish with background color it was not intended.
    FichteFoll committed Sep 4, 2014
    Configuration menu
    Copy the full SHA
    3ea8cb8 View commit details
    Browse the repository at this point in the history
  2. dotted_name should not include linebreaks

    Otherwise, color schemes defining a background color for
    `entitiy.name.function` would make decorators span the remainder of the
    line.
    FichteFoll committed Sep 4, 2014
    Configuration menu
    Copy the full SHA
    42bb653 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2014

  1. Match ALL_CAPS constants in dotted names

    Previously, `self.CONSTANT` was not matched.
    FichteFoll committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    61479aa View commit details
    Browse the repository at this point in the history
  2. print must be an ident if followed by ,

    Or well, it's only valid syntax in Python 3.
    FichteFoll committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    17ea9f5 View commit details
    Browse the repository at this point in the history
  3. Dotted names may span multiple lines

    Even though we can't really match that correctly, at least match the
    leading dot on a new line or after a function call. That's more correct.
    
    Example:
    ident = (value.dotted
             .__init__)
    FichteFoll committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    ee007cb View commit details
    Browse the repository at this point in the history
  4. Add my personal testing file

    It could be of use for regression testing later, or whatever. In any
    case it should illustrate most of the changes of my pull request and can
    easily be extended.
    FichteFoll committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    c9ad654 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2014

  1. Merge pull request #21 from MattDMo/master

    update
    Matt Morrison committed Nov 15, 2014
    Configuration menu
    Copy the full SHA
    b29c10d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #22 from FichteFoll/better_function_match

    Better function match
    Matt Morrison committed Nov 15, 2014
    Configuration menu
    Copy the full SHA
    c481441 View commit details
    Browse the repository at this point in the history
Loading