From 9dde9ab9bc26e1c685a7a4d059be5c98d5d28733 Mon Sep 17 00:00:00 2001
From: dwarkadhish kamthane <dwarkakamthane@gmail.com>
Date: Sat, 7 Oct 2023 11:00:07 +0530
Subject: [PATCH 1/3] Minimization of while loop in Armstrong Numbers

The while loop is removed and simple length calculation is used so the task of minimization of while loop is achieved
---
 maths/armstrong_numbers.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/maths/armstrong_numbers.py b/maths/armstrong_numbers.py
index 26709b428b78..cc8e211dc533 100644
--- a/maths/armstrong_numbers.py
+++ b/maths/armstrong_numbers.py
@@ -29,9 +29,7 @@ def armstrong_number(n: int) -> bool:
     number_of_digits = 0
     temp = n
     # Calculation of digits of the number
-    while temp > 0:
-        number_of_digits += 1
-        temp //= 10
+    number_of_digits=len(str(n))
     # Dividing number into separate digits and find Armstrong number
     temp = n
     while temp > 0:

From 12e707487899f38cc04c563f30dd7ba27ae946dc Mon Sep 17 00:00:00 2001
From: "pre-commit-ci[bot]"
 <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date: Sat, 7 Oct 2023 05:33:32 +0000
Subject: [PATCH 2/3] [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
---
 maths/armstrong_numbers.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/maths/armstrong_numbers.py b/maths/armstrong_numbers.py
index cc8e211dc533..e1c25d4676c3 100644
--- a/maths/armstrong_numbers.py
+++ b/maths/armstrong_numbers.py
@@ -29,7 +29,7 @@ def armstrong_number(n: int) -> bool:
     number_of_digits = 0
     temp = n
     # Calculation of digits of the number
-    number_of_digits=len(str(n))
+    number_of_digits = len(str(n))
     # Dividing number into separate digits and find Armstrong number
     temp = n
     while temp > 0:

From bf7cb317614d80b18555e02d87965d14aaa6a5f3 Mon Sep 17 00:00:00 2001
From: dwarkadhish kamthane <dwarkakamthane@gmail.com>
Date: Tue, 24 Oct 2023 00:06:48 +0530
Subject: [PATCH 3/3] Updated Instruction

The new user can be well guided by the provided Instructions and should follow step by step which is very clearly mentioned
---
 .devcontainer/README.md | 49 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)

diff --git a/.devcontainer/README.md b/.devcontainer/README.md
index ec3cdb61de7a..6ff6d4e7fdd2 100644
--- a/.devcontainer/README.md
+++ b/.devcontainer/README.md
@@ -1 +1,48 @@
-https://code.visualstudio.com/docs/devcontainers/tutorial
+# Prerequisite for the following steps:-
+    Install Visual Studio Code: If you haven't already, download and install Visual Studio Code (VS Code) from the official website: https://code.visualstudio.com/.
+
+    Install Docker: You need Docker to run containers. Download and install Docker for your specific platform. You can find Docker here: https://www.docker.com/get-started.
+
+    Install the "Remote - Containers" Extension: This extension allows you to work with DevContainers in VS Code. Open VS Code, go to the Extensions view by clicking on the Extensions icon in the Activity Bar on the side of the window. Search for "Remote - Containers" and install it.
+
+# Now the steps to start up dev
+
+# Step 1: Create or Use a Project Directory
+
+Create a directory for your project, or navigate to an existing project directory where you want to set up the DevContainer.
+
+# Step 2: Create a DevContainer Configuration File
+
+In your project directory, create a folder named .devcontainer (if it doesn't already exist). This folder will contain your DevContainer configuration files.
+
+Inside the .devcontainer folder, create a devcontainer.json file. This JSON file defines the configuration for your DevContainer. 
+
+# Step 3: Create a Dockerfile (if needed)
+
+In your project directory, create a Dockerfile if you didn't specify one in the devcontainer. This file defines the base image and any additional dependencies you need in your DevContainer.
+Example Dockerfile for a Node.js environment:
+
+Dockerfile
+Copy code
+FROM node:14
+
+# Install additional tools or dependencies
+RUN apt-get update && apt-get install -y git
+# Step 4: Open the Project in a DevContainer
+
+Open your project directory in VS Code.
+
+You'll see a pop-up notification in the bottom-right corner that suggests reopening the project in a DevContainer. Click on "Reopen in Container."
+
+VS Code will build the Docker image (if needed) and start the DevContainer. This might take a few minutes depending on the complexity of your environment.
+
+# Step 5: Work in Your DevContainer
+
+Once the DevContainer is up and running, you can start working in it just like any other VS Code project.
+
+All the extensions and settings defined in your devcontainer.json are available in this containerized environment.
+
+# Step 6: Save and Share Your Configuration
+
+If you want to share your DevContainer setup with others, commit the .devcontainer folder and the Dockerfile to your version control system (e.g., Git).
+That's it! You now have a reproducible DevContainer set up and ready to use. This makes it easy to collaborate with others and ensures a consistent development environment for your project.
\ No newline at end of file
