Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: carbonblack/cbapi-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: carbonblack/cbapi-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr198-response-fixes
Choose a head ref
  • 13 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 9, 2020

  1. Improve response.models.CbChildProcEvent.process 

    Provide as much information as possible, which is particularly useful
for suppressed child processes.
    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    94dd7b5 View commit details
    Browse the repository at this point in the history

  2. Rewrite response.models.Process.require_events 

    The previous implementation was restricted to fetch the first 10k events
from the current segment. This implementation fetches all events limited
by the optional parameters for segment and update times.
    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    fcf37f9 View commit details
    Browse the repository at this point in the history

  3. Rewrite response.models.Process._parse 

    Update instead of overwriting information objects. Attempt to determine
some possibly missing fields from adjacent information objects. Ignore
invalid values and set default values for missing fields.
    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1ca8c63 View commit details
    Browse the repository at this point in the history

  4. Modify response.models.Process.children 

    Return a union of the children in the process summary and childprocs as
either one of the two might be incomplete. Furthermore, return as actual
processes instead of childproc events for consistency with the REST API
and the parents method.
    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    86cc592 View commit details
    Browse the repository at this point in the history

  5. Remove response.models.Process.all_* and require_all_events 

    These methods have been made obsolete by the recent changes to the
require_events and related events methods.
    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    57b5975 View commit details
    Browse the repository at this point in the history

  6. Deduplicate process guid parsing code

    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    257f8eb View commit details
    Browse the repository at this point in the history

  7. Fix for response.models.ProcessQuery.num_children 

    If a selection method is called after the max_children method, then the
num_children member is reset to the default since it's not cloned. This
commit fixes the issue.
    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8ea9748 View commit details
    Browse the repository at this point in the history

  8. Simplify response.utils.convert_from_solr 

    Use dateutil.parser as mentioned by the TODO and used by the other time
and date conversion functions.
    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    22fc720 View commit details
    Browse the repository at this point in the history

  9. Small identation fix in response/util.py

    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d2291fc View commit details
    Browse the repository at this point in the history

  10. Fix response.models.Process.min/max_last_update

    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2bb5153 View commit details
    Browse the repository at this point in the history

  11. Cleanup parent_md5 in response.models.Process 

    Deduplicate and move the removal of parent_md5 to the _parse method.
    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    666b53d View commit details
    Browse the repository at this point in the history

  12. Cleanup response.models.Process.__init__ 

    Ensure that _full_init is True for suppressed processes by calling the
super class constructor before setting the value, and cleanup while we
are at it.
    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5352ab8 View commit details
    Browse the repository at this point in the history

  13. Use the specified process summary API version

    @rlmaers @abowersox-cb
    rlmaers authored and abowersox-cb committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ca8abf8 View commit details
    Browse the repository at this point in the history
Loading