-
Notifications
You must be signed in to change notification settings - Fork 6k
Reorganize container SDK reference for readability and move execution properties to correct section #47738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Copilot finished work on behalf of
gewarren
August 5, 2025 20:57
gewarren
approved these changes
Aug 5, 2025
BillWagner
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM as well.
Let's
baronfel
reviewed
Aug 6, 2025
I have one organizational comment, but otherwise this looks great! |
- Moved ContainerAppCommand, ContainerAppCommandArgs, ContainerAppCommandInstruction, ContainerDefaultArgs, ContainerEnvironmentVariable, ContainerPort, ContainerUser, and ContainerWorkingDirectory from "generated-image-independent metadata" to "execution metadata" section - These properties control how the container runs and can vary across OS/platform combinations - Maintained alphabetical ordering within each section - Updated section headers and property lists accordingly - All internal links and documentation preserved Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
Copilot finished work on behalf of
baronfel
August 6, 2025 14:26
baronfel
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .NET SDK container reference documentation had become difficult to navigate due to its unorganized, wall-of-text format. This PR reorganizes the content into logical categories and addresses feedback to correctly categorize execution-related properties.
Changes Made
Reorganized properties into 4 main categories:
ContainerBaseImage
,ContainerFamily
, andContainerRuntimeIdentifier(s)
that determine which base image is usedContainerImageTag
,ContainerImageFormat
,ContainerLabel
, andContainerRepository
that configure image metadata regardless of target runtimeContainerAppCommand
,ContainerAppCommandArgs
,ContainerAppCommandInstruction
,ContainerDefaultArgs
,ContainerEnvironmentVariable
,ContainerPort
,ContainerUser
,ContainerWorkingDirectory
, andContainerPublishInParallel
that control how containers run and are likely to change across OS/platform combinationsContainerRegistry
,ContainerArchiveOutputPath
, andLocalRegistry
that control where images are stored or publishedAdditional improvements:
The document now provides a much more navigable reference that helps developers quickly find the properties they need based on what aspect of containerization they want to control, with proper categorization of execution-related properties.
Fixes #45910.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews