Skip to content

Commit ebcc664

Browse files
committed
- Moved integration tests to separate source root
- Implemented Tests for IntrospectionService
1 parent 88d3ba8 commit ebcc664

36 files changed

+518
-93
lines changed

src/test/java/de/danielbechler/diff/ObjectDifferIntegrationTests.java renamed to src/integration-test/java/de/danielbechler/diff/ObjectDifferITCase.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package de.danielbechler.diff;
1818

1919
import de.danielbechler.diff.collection.*;
20+
import de.danielbechler.diff.helper.*;
2021
import de.danielbechler.diff.map.*;
2122
import de.danielbechler.diff.mock.*;
2223
import de.danielbechler.diff.visitor.*;
@@ -26,13 +27,13 @@
2627
import java.util.ArrayList;
2728
import java.util.*;
2829

29-
import static de.danielbechler.diff.NodeAssertions.*;
30-
import static de.danielbechler.diff.TestGroups.*;
30+
import static de.danielbechler.diff.helper.NodeAssertions.*;
31+
import static de.danielbechler.diff.helper.TestGroups.*;
3132
import static java.util.Arrays.*;
3233

3334
/** @author Daniel Bechler */
3435
@Test(groups = TestGroups.INTEGRATION)
35-
public class ObjectDifferIntegrationTests
36+
public class ObjectDifferITCase
3637
{
3738
private ObjectDiffer objectDiffer;
3839

src/integration-test/java/de/danielbechler/diff/integration/AdditionIntegrationITCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import de.danielbechler.diff.mock.*;
2121
import org.testng.annotations.*;
2222

23-
import static de.danielbechler.diff.NodeAssertions.*;
23+
import static de.danielbechler.diff.helper.NodeAssertions.*;
2424

2525
/** @author Daniel Bechler */
2626
public class AdditionIntegrationITCase

src/integration-test/java/de/danielbechler/diff/integration/DeepDiffingCollectionItemChangeITCase.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
import java.util.*;
2525

26-
import static de.danielbechler.diff.NodeAssertions.*;
26+
import static de.danielbechler.diff.helper.NodeAssertions.*;
2727

2828
/** @author Daniel Bechler */
2929
public class DeepDiffingCollectionItemChangeITCase
@@ -35,7 +35,6 @@ public void test_returns_full_property_graph_of_added_collection_items()
3535
final Map<String, ObjectWithString> working = Collections.singletonMap("foo", new ObjectWithString("bar"));
3636

3737
final ObjectDifferBuilder objectDifferBuilder = ObjectDifferBuilder.startBuilding();
38-
objectDifferBuilder.configure().introspection().includeChildrenOfNodeWithState(DiffNode.State.ADDED);
3938
final ObjectDiffer differ = objectDifferBuilder.build();
4039

4140
final DiffNode node = differ.compare(working, base);

src/integration-test/java/de/danielbechler/diff/integration/IgnoreITCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import de.danielbechler.diff.visitor.*;
2222
import org.testng.annotations.*;
2323

24-
import static de.danielbechler.diff.NodeAssertions.*;
24+
import static de.danielbechler.diff.helper.NodeAssertions.*;
2525

2626
/** @author Daniel Bechler */
2727
public class IgnoreITCase

src/integration-test/java/de/danielbechler/diff/issues/issue15/CircularReferenceDetectionBasedOnEqualsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package de.danielbechler.diff.issues.issue15;
1818

1919
import de.danielbechler.diff.*;
20+
import de.danielbechler.diff.helper.*;
2021
import de.danielbechler.diff.mock.*;
2122
import org.testng.annotations.*;
2223

@@ -31,7 +32,6 @@ public class CircularReferenceDetectionBasedOnEqualsTest
3132
public void setUp() throws Exception
3233
{
3334
final ObjectDifferBuilder configuration = ObjectDifferBuilder.startBuilding();
34-
configuration.configure().introspection().includeChildrenOfNodeWithState(DiffNode.State.ADDED);
3535
configuration.configure()
3636
.circularReferenceHandling()
3737
.matchCircularReferencesUsing(EQUALS_METHOD);

src/integration-test/java/de/danielbechler/diff/issues/issue15/CircularReferenceDetectionBasedOnIdentityTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package de.danielbechler.diff.issues.issue15;
1818

1919
import de.danielbechler.diff.*;
20+
import de.danielbechler.diff.helper.*;
2021
import de.danielbechler.diff.mock.*;
2122
import org.testng.annotations.*;
2223

@@ -31,7 +32,6 @@ public class CircularReferenceDetectionBasedOnIdentityTest
3132
public void setUp() throws Exception
3233
{
3334
final ObjectDifferBuilder configuration = ObjectDifferBuilder.startBuilding();
34-
configuration.configure().introspection().includeChildrenOfNodeWithState(DiffNode.State.ADDED);
3535
configuration.configure()
3636
.circularReferenceHandling()
3737
.matchCircularReferencesUsing(EQUALITY_OPERATOR);

src/integration-test/java/de/danielbechler/diff/issues/issue15/CircularReferenceIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import org.fest.assertions.api.*;
2323
import org.testng.annotations.*;
2424

25-
import static de.danielbechler.diff.NodeAssertions.*;
25+
import static de.danielbechler.diff.helper.NodeAssertions.*;
2626

2727
/** @author Daniel Bechler */
2828
public class CircularReferenceIntegrationTest

src/integration-test/java/de/danielbechler/diff/issues/issue15/GraphITCase.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,12 @@
1717
package de.danielbechler.diff.issues.issue15;
1818

1919
import de.danielbechler.diff.*;
20+
import de.danielbechler.diff.helper.*;
2021
import de.danielbechler.diff.visitor.*;
2122
import org.testng.annotations.*;
2223

23-
import static de.danielbechler.diff.NodeAssertions.assertThat;
2424
import static de.danielbechler.diff.NodePath.*;
25+
import static de.danielbechler.diff.helper.NodeAssertions.assertThat;
2526
import static org.fest.assertions.api.Assertions.assertThat;
2627

2728
/**

src/integration-test/java/de/danielbechler/diff/issues/issue70/PersonDiffITCase.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package de.danielbechler.diff.issues.issue70;
22

33
import de.danielbechler.diff.*;
4+
import de.danielbechler.diff.helper.*;
45
import de.danielbechler.diff.visitor.*;
56
import org.testng.annotations.*;
67

src/main/java/de/danielbechler/diff/ComparisonConfiguration.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
/** @author Daniel Bechler */
44
public interface ComparisonConfiguration
55
{
6+
Of ofNode(NodePath nodePath);
7+
8+
Of ofType(Class<?> type);
9+
10+
OfPrimitiveTypes ofPrimitiveTypes();
11+
612
public interface Of
713
{
814
ComparisonConfiguration toUse(ComparisonStrategy comparisonStrategy);
@@ -18,10 +24,4 @@ public interface OfPrimitiveTypes
1824
{
1925
ComparisonConfiguration toTreatDefaultValuesAs(PrimitiveDefaultValueMode primitiveDefaultValueMode);
2026
}
21-
22-
Of ofNode(NodePath nodePath);
23-
24-
Of ofType(Class<?> type);
25-
26-
OfPrimitiveTypes ofPrimitiveTypes();
2727
}

0 commit comments

Comments
 (0)