Skip to content

Java docs in some exposed method are outdated when migrated from JOSDK 4.x to 5.x #2890

@afalhambra-hivemq

Description

@afalhambra-hivemq

Bug Report

Minor but misleading Java doc in some methods are not properly updated when moving from JOSDK 4.x to JOSDK 5.x. Seems there are still some leftovers.
For example this one here: https://github.com/operator-framework/java-operator-sdk/blob/v4.9.7/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/UpdateControl.java#L40-L57

It says:

... Preferred way to update the status. It does not do optimistic locking. Uses JSON Patch to patch...

That no longer holds true, as this was removed with the JOSDK 5.x release: cde1bf2#diff-3a1255a04c187002f628fcfe29a702c78ffc855d6a5709f64fb0b8098d610afc

-      originalResource.getMetadata().setResourceVersion(null);
-      resource.getMetadata().setResourceVersion(null);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions