Invalid "phpunit.mockMethod" error

[liayn]

We are getting:

Trying to mock an undefined method addCacheTags() on class TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController

PHP: 8.4
phpunit: 10.5.45
phpstan: 2.1.11
phpstan-phpunit: 2.0.5

It looks like #222 is related to this.

[liayn]

Downgrading to phpstan-phpunit: 2.0.4 solves the issue.

[ondrejmirtes]

Please show code that causes this error. A full example that we can reproduce the problem with.

[liayn]

I tried to extract this from our code base:

use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;

class SomeTest extends BaseTestCase {

protected MockObject|TypoScriptFrontendController $tsfe;

protected function setUp(): void
{
    $this->tsfe = $this->getMockBuilder(TypoScriptFrontendController::class)
            ->onlyMethods(['addCacheTags', 'getLanguage'])
            ->disableOriginalConstructor()
            ->getMock();

   $language = ....;
// this works
   $this->tsfe->method('getLanguage')->willReturn($language);
}

#[Test]
public function sometest(): void
{
// this causes the error
     $this->tsfe->expects(self::once())->method('addCacheTags');
}

This is the mocked class:
https://github.com/TYPO3/typo3/blob/12.4/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php

[ondrejmirtes]

This:

protected MockObject|TypoScriptFrontendController $tsfe;

Should be an intersection type:

protected MockObject&TypoScriptFrontendController $tsfe;

Can you try that?

[ondrejmirtes]

I confirm that using the proper intersection type fixes it.

[liayn]

Yes, fixes it.

So we have two issues here now:

• The error message is misleading, as it claims something that is not true. ("method X does not exist on Y", but it does)
• Older code-bases where intersection types haven't been used yet are now getting errors despite 2.0.5 being a bugfix-release (in SemVer terms)

I have no problem with adjusting the code-base to intersection types, but those who need to support PHP < 8.1 will.

[ondrejmirtes]

Your code has always been wrong because it's been reporting this error even on 2.0.4 and prior:

  40     Call to an undefined method aaa\Foo|PHPUnit\Framework\MockObject\MockObject::expects().
         🪪  method.notFound

That said, I managed to improve the extension not to report "method X does not exist on Y": 0aef32f

I have no problem with adjusting the code-base to intersection types, but those who need to support PHP < 8.1 will.

Intersection types work in PHPDocs too. In fact, it was where they originated: https://phpstan.org/blog/union-types-vs-intersection-types

[liayn]

Your code has always been wrong because

Argss... I forgot to disable the old baseline for the test. Sorry.

That said, I managed to improve the extension not to report "method X does not exist on Y": 0aef32f

🤝👍

Thanks for the very fast support here. Highly appreciated.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.