[RFC] Report error for non final class without children

[VincentLanglet]

Psalm just created a ClassMustBeFinal error with some explanation:

• Harder BC-policy
• Final classes are optimized by PHP/Opcache

vimeo/psalm#11279

I was wondering if the same report would be

• easy to implement for phpstan
• a good idea for phpstan-strict-rule

It will report an error if

• The class is not final
• The class has no children
• The class does not have @final annotation
• The class does not have @api annotation
• Something else ?

Also, best would be for phpstan-doctrine plugin to automatically ignore this rule for the src/Entity folder.

[ondrejmirtes]

Trivially easy to implement with collectors, I like final classes, but I completely disagree with the premise to push this onto users.

So feel free to publish this as your own package 😊

[VincentLanglet]

Trivially easy to implement with collectors
So feel free to publish this as your own package 😊

Sure, I'd like to try implementing the rule for my project but any recommendation about how to do it ?

[ondrejmirtes]

https://phpstan.org/developing-extensions/collectors

1. One Collector collecting non-final non-abstract classes.
2. Another collector collecting extended classes.
3. CollectedDataNode rule comparing these two data sets and deciding what to report.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.