Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: robotframework/SeleniumLibrary
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: robotframework/SeleniumLibrary
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix-1791
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Oct 12, 2022

  1. Unify "index" type of keyword arguments. 

    create_webdriver was marked as returning a str, however, its return
value is coming from register_driver which is documented to return int.
These where changed to return actual int.

switch_driver was only accepting str as "index_or_alias". While aliases
are str's since create_driver now returns the actual index as int,
accepting both types makes more sense.

select and unselect list keywords where typehinted to receive only str
as index type - when called from python side, this does not make much
sense so changed those to int as RF should do type conversion
automatically.

Fixes #1791
    @rasjani
    rasjani committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    d7a6152 View commit details
    Browse the repository at this point in the history
Loading