I want to show some improvements which an AI made to SqlExecutionArea.cpp

[Stheel83]

Hi all,
i want to show you some improvements which an AI (Claude.ai) made to SqlExecutionArea.cpp.
https://github.com/sqlitebrowser/sqlitebrowser/blob/continuous/src/SqlExecutionArea.cpp

I have zero knowlegde of C++ so i can´t tell if this is usefull in any way.
Is it even allowed to use AI Code in this project, please let me know.

But i used the AI for other codings and it was very usefull, so i tried it again in this example.

The (maybe) improved code is attached as a txt file and here are the improvements the AI made:

"Here are the key improvements I made to the code:

1. Code Organization:
   Created helper methods setupModel(), setupConnections(), and setupShortcuts() to improve readability and organization of the constructor
   Moved class members initialization to the constructor's initialization list
   Added missing initialization of showErrorIndicators in the constructor

2. Constants and Style:
   Created a namespace with constants for magic numbers and repeated strings (like the 300px max column width and style sheets)
   Consistent formatting and indentation throughout the code

3. Error Handling and Flow Control:
   Improved error handling in file operations with early returns and clearer structure
   More consistent use of braces for all if statements to prevent bugs
   Better structure in complex methods like fileChanged()

4. Performance Optimizations:
   More efficient string handling
   Cleaner implementation of UI updates

5. Bug Fix:
   Fixed a potential issue with the file change handling and follow_mode setting

6. Readability Improvements:
   Added clearer variable names (e.g., using auto for shortcut pointers)
   Better spacing and code organization throughout
   Simplified conditional expressions (e.g., using ternary operators for simple if/else conditions)
   Improved formatting of multi-parameter function calls

7. Header Modifications:
   While I focused on improving the .cpp file, you would also want to update the corresponding header file to match these changes, including:

• Adding the new private methods: setupModel(), setupConnections(), and setupShortcuts()
• Making sure showErrorIndicators is properly declared

8. Code Duplication Reduction:
   Consolidated repeated code in error message handling
   Standardized style sheet application throughout the code

9. Memory Management:
   No memory leaks were found, but I maintained proper resource cleanup with explicit delete ui in the destructor

10. Maintainability Enhancements:
    Better organization of related functionality into cohesive methods
    Clearer separation of UI concerns from business logic
    More descriptive variable names in some places

11. Modern C++ Practices:
    Used more consistent naming conventions
    Applied more consistent use of braces and formatting
    Used nullptr instead of NULL where appropriate

These improvements should make the code more maintainable, slightly more efficient, and less error-prone. The code structure is now clearer, making it easier for other developers to understand and modify in the future."

So please let me know your thoughts.

Improved SqlExecutionArea.txt

[chrisjlocke]

Is it even allowed to use AI Code in this project, please let me know

AI is great at assisting with pointers in your code or suggesting fixes but you can't change great swaths of code without knowing what its doing. The code it suggests could very well be helpful, but it certainly won't be bug-free, and after your submission, who is going to continue forward maintaining it, not knowing what its doing?

Also, if you have a great broom, but replace the wooden handle with a plastic one, and replace the head with a wider head, is it still the same broom anymore?

[justinclift]

Is it even allowed to use AI Code in this project, please let me know.

I'd lean more towards "No", as the licensing of AI generated code is extremely unclear, and won't be clear for at least a few more years it seems.

[lucydodo]

I am supportive of using AI-generated code in project, provided that certain exceptions are met.
The exceptions are as follows:

• The code submitter must have a sufficient understanding of both C++ and the AI-generated code.
• The code should not be entirely generated by AI.

By "entirely generated by AI", I mean cases where AI creates a specific feature from start to finish,
rather than just performing simple refactoring or modifications.

The reason I oppose entirely AI-generated code is due to licensing concerns, as @justinclift mentioned.
There have already been cases where various AI tools have generated code with licenses such as GPL.
If such code were incorportaed into our poject, it could conflict wiht out project's license and create unnecessary issues.

Additionally, I want to make it clear that this is my personal opinion as one of the maintainers, not an officially agreed stance of team.
This means that additional discussions within the community and between teams are necessary.

[Stheel83]

Thank you very much for your thoughts and explanations.

I totally didn´t think of the maintenance part.

So i can only do my hobby stuff with AI and play around with it.

[chrisjlocke]

So i can only do my hobby stuff with AI and play around with it

The more you play around with it, the more you'll understand it, then the code you submit here will be your own code.
There is nothing wrong with learning from ai, but you can't just submit huge blocks of AI code without knowing what its doing and why.

Think of it the other way.
You're going in hospital for surgery. WOuld you prefer a doctor with experience, or some janitor who's asked chatGPT what to do?
The information the janitor has got could be right, and even more up to date than what the experienced doctor may do .. but he doesn't have the skills to use that knowledge.

[Stheel83]

Ok, thanks again for the explanation. I think i need more expierience.

[chrisjlocke]

And there is nothing wrong with that. This project looks forward to your next submissions. :)