add psalm and travis check

Author: Dominik Liebler

.travis.yml

@@ -24,3 +24,4 @@ install:
 script:
   - vendor/bin/phpunit
   - vendor/bin/phpcs .
+  - vendor/bin/psalm --show-info=false

Behavioral/ChainOfResponsibilities/Tests/ChainTest.php

@@ -5,7 +5,10 @@
 use DesignPatterns\Behavioral\ChainOfResponsibilities\Handler;
 use DesignPatterns\Behavioral\ChainOfResponsibilities\Responsible\HttpInMemoryCacheHandler;
 use DesignPatterns\Behavioral\ChainOfResponsibilities\Responsible\SlowDatabaseHandler;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
+use Psr\Http\Message\RequestInterface;
+use Psr\Http\Message\UriInterface;
 
 class ChainTest extends TestCase
 {
@@ -24,11 +27,11 @@ protected function setUp(): void
 
     public function testCanRequestKeyInFastStorage()
     {
-        $uri = $this->createMock('Psr\Http\Message\UriInterface');
+        $uri = $this->createMock(UriInterface::class);
         $uri->method('getPath')->willReturn('/foo/bar');
         $uri->method('getQuery')->willReturn('index=1');
 
-        $request = $this->createMock('Psr\Http\Message\RequestInterface');
+        $request = $this->createMock(RequestInterface::class);
         $request->method('getMethod')
             ->willReturn('GET');
         $request->method('getUri')->willReturn($uri);
@@ -38,11 +41,11 @@ public function testCanRequestKeyInFastStorage()
 
     public function testCanRequestKeyInSlowStorage()
     {
-        $uri = $this->createMock('Psr\Http\Message\UriInterface');
+        $uri = $this->createMock(UriInterface::class);
         $uri->method('getPath')->willReturn('/foo/baz');
         $uri->method('getQuery')->willReturn('');
 
-        $request = $this->createMock('Psr\Http\Message\RequestInterface');
+        $request = $this->createMock(RequestInterface::class);
         $request->method('getMethod')
             ->willReturn('GET');
         $request->method('getUri')->willReturn($uri);

Behavioral/Observer/UserObserver.php

@@ -2,25 +2,27 @@
 
 namespace DesignPatterns\Behavioral\Observer;
 
+use SplSubject;
+
 class UserObserver implements \SplObserver
 {
     /**
-     * @var User[]
+     * @var SplSubject[]
      */
     private $changedUsers = [];
 
     /**
      * It is called by the Subject, usually by SplSubject::notify()
      *
-     * @param \SplSubject $subject
+     * @param SplSubject $subject
      */
-    public function update(\SplSubject $subject)
+    public function update(SplSubject $subject)
     {
         $this->changedUsers[] = clone $subject;
     }
 
     /**
-     * @return User[]
+     * @return SplSubject[]
      */
     public function getChangedUsers(): array
     {

Behavioral/Specification/AndSpecification.php

@@ -10,7 +10,7 @@ class AndSpecification implements Specification
     private $specifications;
 
     /**
-     * @param Specification[] ...$specifications
+     * @param Specification[] $specifications
      */
     public function __construct(Specification ...$specifications)
     {

Behavioral/Specification/OrSpecification.php

@@ -10,14 +10,14 @@ class OrSpecification implements Specification
     private $specifications;
 
     /**
-     * @param Specification[] ...$specifications
+     * @param Specification[] $specifications
      */
     public function __construct(Specification ...$specifications)
     {
         $this->specifications = $specifications;
     }
 
-    /**
+    /*
      * if at least one specification is true, return true, else return false
      */
     public function isSatisfiedBy(Item $item): bool

Creational/AbstractFactory/ShippableProduct.php

@@ -5,12 +5,12 @@
 class ShippableProduct implements Product
 {
     /**
-     * @var float
+     * @var int
      */
     private $productPrice;
 
     /**
-     * @var float
+     * @var int
      */
     private $shippingCosts;
 

Creational/StaticFactory/FormatNumber.php

@@ -6,6 +6,6 @@ class FormatNumber implements Formatter
 {
     public function format(string $input): string
     {
-        return number_format($input);
+        return number_format((int) $input);
     }
 }

Creational/StaticFactory/Tests/StaticFactoryTest.php

@@ -2,25 +2,21 @@
 
 namespace DesignPatterns\Creational\StaticFactory\Tests;
 
+use DesignPatterns\Creational\StaticFactory\FormatNumber;
+use DesignPatterns\Creational\StaticFactory\FormatString;
 use DesignPatterns\Creational\StaticFactory\StaticFactory;
 use PHPUnit\Framework\TestCase;
 
 class StaticFactoryTest extends TestCase
 {
     public function testCanCreateNumberFormatter()
     {
-        $this->assertInstanceOf(
-            'DesignPatterns\Creational\StaticFactory\FormatNumber',
-            StaticFactory::factory('number')
-        );
+        $this->assertInstanceOf(FormatNumber::class, StaticFactory::factory('number'));
     }
 
     public function testCanCreateStringFormatter()
     {
-        $this->assertInstanceOf(
-            'DesignPatterns\Creational\StaticFactory\FormatString',
-            StaticFactory::factory('string')
-        );
+        $this->assertInstanceOf(FormatString::class, StaticFactory::factory('string'));
     }
 
     public function testException()

More/EAV/Entity.php

@@ -2,10 +2,12 @@
 
 namespace DesignPatterns\More\EAV;
 
+use SplObjectStorage;
+
 class Entity
 {
     /**
-     * @var \SplObjectStorage
+     * @var SplObjectStorage<Value,Value>
      */
     private $values;
 
@@ -20,7 +22,7 @@ class Entity
      */
     public function __construct(string $name, $values)
     {
-        $this->values = new \SplObjectStorage();
+        $this->values = new SplObjectStorage();
         $this->name = $name;
 
         foreach ($values as $value) {

More/EAV/Value.php

@@ -24,6 +24,6 @@ public function __construct(Attribute $attribute, string $name)
 
     public function __toString(): string
     {
-        return sprintf('%s: %s', $this->attribute, $this->name);
+        return sprintf('%s: %s', (string) $this->attribute, $this->name);
     }
 }