Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CacheControl/json-rules-engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.3.4
Choose a base ref
...
head repository: CacheControl/json-rules-engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.3.5
Choose a head ref
  • 4 commits
  • 4 files changed
  • 3 contributors

Commits on Apr 26, 2019

  1. Use Array.isArray instead of instanceof 

    `instanceof` does not always return true for an array even if `array.isArray()`
return true and `Object.prototype.toString()` returns `[Object Array]`

http://blog.niftysnippets.org/2010/09/say-what.html#instanceof
https://stackoverflow.com/questions/28779255/is-instanceof-array-better-than-isarray-in-javascript

Fixes #124
    George Thomas committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    1b9968e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #128 from thegeorgeous/124-fix-instanceof 

    Use Array.isArray instead of instanceof
    @CacheControl
    CacheControl authored Apr 26, 2019
    Configuration menu
    Copy the full SHA
    5a2723f View commit details
    Browse the repository at this point in the history

  3. Update changelog

    Cache Hamm committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    eb438cd View commit details
    Browse the repository at this point in the history

  4. 2.3.5

    Cache Hamm committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    5dad489 View commit details
    Browse the repository at this point in the history
Loading