fix order of Serialize for linux build (dotnet#17119)

davmason · web-flow · commit d67a99436216 · 2018-03-22T11:44:37.000-07:00
Fix for #17116. The build would work fine for dynamic events on Windows, but on Linux clang always takes the overloads with &lt;Head, Tail...&gt; until there are no arguments, then complains about no overload takes 0 arguments.
diff --git a/src/gc/gcevent_serializers.h b/src/gc/gcevent_serializers.h
@@ -106,33 +106,33 @@ struct EventSerializationTraits<uint32_t>
  * Given a list of arguments , returns the total size of
  * the buffer required to fully serialize the list of arguments.
  */
-template<class Head, class... Tail>
-size_t SerializedSize(Head head, Tail... tail)
-{
-    return EventSerializationTraits<Head>::SerializedSize(head) + SerializedSize(tail...);
-}
-
 template<class Head>
 size_t SerializedSize(Head head)
 {
     return EventSerializationTraits<Head>::SerializedSize(head);
 }
 
+template<class Head, class... Tail>
+size_t SerializedSize(Head head, Tail... tail)
+{
+    return EventSerializationTraits<Head>::SerializedSize(head) + SerializedSize(tail...);
+}
+
 /*
  * Given a list of arguments and a list of actual parameters, serialize
  * the arguments into the buffer that's given to us.
  */
-template<class Head, class... Tail>
-void Serialize(uint8_t** buf, Head head, Tail... tail)
+template<class Head>
+void Serialize(uint8_t** buf, Head head)
 {
     EventSerializationTraits<Head>::Serialize(head, buf);
-    Serialize(buf, tail...);
 }
 
-template<class Head>
-void Serialize(uint8_t** buf, Head head)
+template<class Head, class... Tail>
+void Serialize(uint8_t** buf, Head head, Tail... tail)
 {
     EventSerializationTraits<Head>::Serialize(head, buf);
+    Serialize(buf, tail...);
 }
 
 } // namespace gc_event
