Skip to content

Commit fe2adec

Browse files
Merge pull request dotnet#24616 from BruceForstall/RemoveJenkinsBUILD_URLVariable
Remove Jenkins BUILD_URL environment variable
2 parents b096720 + 9104ae2 commit fe2adec

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

eng/format-job.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@ jobs:
3636
displayName: Publish format.patch
3737
inputs:
3838
PathtoPublish: '$(Build.SourcesDirectory)/format.patch'
39-
ArtifactName: $(osGroup).$(archType) format.patch
39+
ArtifactName: format.$(osGroup).$(archType).patch
4040
continueOnError: true
4141
condition: failed()

tests/scripts/format.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,12 +172,18 @@ def main(argv):
172172
os.remove(bootstrapPath)
173173

174174
if returncode != 0:
175-
buildUrl = my_env["BUILD_URL"]
176175
print("There were errors in formatting. Please run jit-format locally with: \n")
177176
print(errorMessage)
178177
print("\nOr download and apply generated patch:")
179-
print("wget " + buildUrl + "artifact/format.patch")
180-
print("git apply format.patch")
178+
print("1. From the GitHub 'Checks' page on the Pull Request, with the failing Formatting")
179+
print(" job selected (e.g., 'Formatting Linux x64'), click the 'View more details on")
180+
print(" Azure Pipelines' link.")
181+
print("3. Select the 'Summary' tab.")
182+
print("4. Open the 'Build artifacts published' entry.")
183+
print("5. Find the link to the OS/architecture appropriate format patch file.")
184+
print("6. Click on the link to download it.")
185+
print("7. Unzip the patch file.")
186+
print("8. git apply format.patch")
181187

182188
return returncode
183189

0 commit comments

Comments
 (0)