| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If page implements beforeunload handler
<script>
window.addEventListener('beforeunload', e => {
e.preventDefault();
});
</script>
the browser should display a message in a confirmation dialog box
to inform the user whether he/she wants to really leave.
This is already implemented in simplebrowser, and it boils down
to making triggerWebAction call and proper handling of windowCloseRequested signal.
Pick-to: 6.10 6.9 6.8
Change-Id: I91341cd7cff82f8f7dbddf6c9224473e9cfb31b9
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Fix a runtime warning on some platforms (macos, for example), by using
the sequences property instead of sequence (without s).
Pick-to: 6.10
Fixes: QTBUG-138734
Change-Id: Ia531087222dee14cfbf2683df398700664505b26
Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: Icef324886802532cad05f7c71ae10deafc2a77d1
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
|
|
|
|
|
|
|
|
|
| |
Interestingly, none of these triggered qmllint warnings.
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: I04618ff65448c9f23bce4c23a80b665e66d20956
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
The top and bottom margins were removed from the find box as that fixes
its appearance visually. The rectangle spills out of the field
otherwise.
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: I4ff2559fa0cbd83bc40b15a1acb52bfeffad7cf8
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These signals don't pass any arguments. The handlers were mistakenly
given parameters for some values. These are always undefined and can
shadow the actual value intended to be queried.
Amends f55df96ab51e590f73a7878742662758c1c4369b
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: Ide297f7abae0b4bb9aff3a8c6ce09555eb72df9b
Reviewed-by: Semih Yavuz <semih.yavuz@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Also fix small typo and style issues.
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: I36109e36773a10914a996f6beec0b9758a671c2b
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
|
|
|
|
|
|
|
|
|
| |
Also make the dependency on BrowserWindow of WebAuthDialog explicit by
requiring browserInstance.
Task-number: QTBUG-138589
Change-Id: I7f424c9bf6af775ef7e80048b03f7cbbbb67ee79
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to a cyclical dependency error, declare applicationRoot to be a
QtObject. This required all its usages to be as-casted to
ApplicationRoot to avoid warnings. BrowserWindow used in WebAuthDialog
has the same issue. Work around that issue by using parents. This error
is fixed on dev and this these changes are reverted in a following
commit targetting only dev.
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: I7327ec298432b1cfbb6d34f994b41cff0ab19eab
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
|
|
|
|
|
|
|
|
|
| |
We can use optional chaining and nullish coalescing instead.
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: Ic6f1467dbada37010d593df492b7a2efee630996
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Qualify lookups to it, set its actual type, set pragma
ComponentBehavior.
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: Ic6b7cc6f16af1677ac4e2b2bcd57aa00a686ca6f
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
It needs to be used all over the place and is too long. Shorten it for
readability.
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: I170e2ec554944ad2a712778d1508ad08d71fa796
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: I4f05186032f9c074391aafb55001801c99a54eab
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
There is also no need to check for loadFromModule failing to load the
module as we explicitly added it from CMake.
Task-number: QTBUG-138589
Pick-to: 6.10
Change-Id: Iddc1aae0c66ff6f4fc3ddaa43b8e066c16952b0c
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Use modern CMake api for QML modules and policies
-Use loadFromModule
-Keep support for qmake by adding/updating qmldir/qrc files
-Update resource paths to /qt/qml/<module> in accordance with QTP0001
-Qualify lookups
-Set ids in Components to be Bound
-Use Layout.preferredWith instead of width inside a Layout
With this, we can now set the maximum allowed number of qmllint warnings
to 0 in preparation of them being enforced in the CI.
Pick-to: 6.10
Change-Id: Ia3ebab364274ead4f1506bb3e2fcdac99ec404b2
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Use modern CMake api for QML modules and policies
-Use loadFromModule
-Keep support for qmake by adding/updating qmldir/qrc files
-Update resource paths to /qt/qml/<module> in accordance with QTP0001
-Qualify lookups
-Set ids in Components to be Bound
-Use Layout.preferredWith instead of width inside a Layout
With this, we can now set the maximum allowed number of qmllint warnings
to 0 in preparation of them being enforced in the CI.
Pick-to: 6.10
Change-Id: I4d89e23f175c46b0dd565bf089db93baebea7b0c
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-111907
Pick-to: 6.10
Change-Id: I1b662a7008f705a3c68d6a1ef1564f1d71ad309a
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Modified CMake file to use qt_add_qml_module() to add QML files,
instead of using the Qt 5 way of including QML files via .qrc.
Fixes: QTBUG-138190
Pick-to: 6.10 6.9
Change-Id: I0779aaa986050d6fae0f185ca36136c23fd4db80
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Modified CMake File to use qt_add_qml_module() to add QML files,
instead of using the Qt 5 way of including QML files via .qrc.
Fixes: QTBUG-138190
Pick-to: 6.10 6.9
Change-Id: I108c1306b76b6c736805bc1529511519985f506f
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
Make simplebrowser deployable.
Pick-to: 6.9
Change-Id: I4717c30d1048c0c76306a71c657499b997a146c4
Reviewed-by: Moss Heim <moss.heim@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When configuring qtwebengine as its own module, Svg is not searched as
an optional component, leading to the warning in
examples/pdf/CMakeLists.txt always being printed even when QtSvg is
available.
Add Svg as an optional package in find_package and move the checks
into the individual examples so the warning will also appear when the
individual example is built.
Pick-to: 6.8 6.9
Change-Id: I387dfd70ae1abc1a70f28dbfe74ac45b75bdf387
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Remove an unused member, dynamically populate the policy combo box so
its items and data stay synced, fix a documentation typo, and simplify a
few expressions.
Pick-to: 6.8 6.9
Change-Id: I37997fbbeca51ed4c71c83a86d989917ce92b3df
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.8 6.9
Change-Id: Ib3ff4394009364c673ef45e4244b65ed38e41379
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
| |
This conflicts with a target named server in qtbase benchmarks. Give the
targets more unique names.
Pick-to: 6.8 6.9
Change-Id: I52d71e37c976ada5bf48813ecaf200923b07aef6
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.9 6.8
Change-Id: I0e973f599218a719aa8cff0ce65c4d35cefe4b3f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Add *.pdf to open dialog filter.
Change-Id: Ifc70c1dc1356341bea78d46f775a2c517e041b15
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
All our other examples use 3.16, and cmake 3.30 now gives a deprecation
warning about this.
Pick-to: 6.8 6.9
Change-Id: If2aff723cedab0339ba506484b44bddd89858307
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
| |
Clang warns about these when compiling.
Pick-to: 6.8 6.9
Change-Id: Idf0daf9f4b7c71fefaddb4531d9ed164e90d118e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Also validate return value of QIODevice::open() and QBuffer::open()
calls.
Pick-to: 6.8 6.9
Change-Id: I71ea58f62cab5aafdd2b4eca217394dddf0033cd
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Moss Heim <moss.heim@qt.io>
|
|
|
|
|
|
|
| |
This is a wrapper designed to handle profile construction from qml.
Change-Id: I6f3c9e06052c08e81422e148c75c599cc361be95
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a wrapper designed to handle profile construction.
The QWebEngineProfile class allows the modification of profile storage
properties, which is against chromium profile design. Changing storage
properties requires the recreation of storage and network context
leading to hacks, which in turn leads to bugs.
The QWebEngineProfileBuilder aims to prevent modification of storage
properties and set them at the profile creation time. The current change
introduces new APIs without deprecating the storage setters in the
QWebEngineProfile class. The final goal is to deprecate the storage
setters and constructor from QWebEngineProfile and use the
QWebEngineProfileBuilder to create profiles.
Task-number: QTBUG-66068
Change-Id: I3c2562c9e1445708f0dbdeae5783a8c7d38313af
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
REUSE.toml files are read by reuse to complement or override the
copyright and licensing information found in file.
The use of REUSE.toml files was introduced in REUSE version 3.1.0a1.
This reuse version is compatible with reuse specification
version 3.2 [1].
With this commit's files,
* The SPDX document generated by reuse spdx conforms to SPDX 2.3,
* The reuse lint command reports that the Qt project is reuse compliant.
In order to be reuse compliant all the licenses referenced in file
or within a REUSE.toml file must be present in the LICENSES
directory at the base of the module.
The missing licenses are added.
[1]: https://reuse.software/spec-3.2/
Task-number: QTBUG-124453
Task-number: QTBUG-125211
Pick-to: 6.8
Change-Id: Ic8c34b884bae1151f5d912f375bf87378e6e9a3d
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
| |
Fixes a couple of broken links, a broken list, and a missing \c tag.
Pick-to: 6.8
Change-Id: I57bd37aea88a3780b1897ab0223d7964e6399755
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify the already existing downloadRequest() API. Now the requests
not necessarily have to be answered in a directly connected signal
handler and the API users can postpone their user's decision.
The only exceptions are automatically accepted save page requests. There
is no better place to call their callback than directly after the signal
emission.
Adapt auto tests to the new lifecycle of download items. Modify the
quicknanobrowser example to use a simple async method to wait for the
user's decision. Keep simplebrowser to use its old synchronous method
to illustrate that it's still possible. Correct documentation at some
places.
[ChangeLog] QWebEngineProfile::downloadRequested() is not limited to
synchronous usage anymore. QWebEngineDownloadRequest can be accepted
or rejected later without blocking the browsing session.
Fixes: QTBUG-118584
Change-Id: Ic1be6508126574dc77aa686f85bf35feafdb080d
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a second attempt at getting rid of the deprecation warnings
caused by the new logging category macros in 6.9. These cause build
failures on warnings-as-errors configurations, and need to be fixed
properly without affecting backwards compatibility.
The change introduces a new Q_WEBENGINE_LOGGING_CATEGORY macro,
intended to be used across the WebEngine sources. The macro is
not exported to users, so the QtPdf example that declares its
own logging category uses an #ifdef instead.
The new macro is placed in its own header inside src/core/,
and is intended to be removed whenever the next LTS release
allows us to break compatibility with 6.8, and just directly
use Q_STATIC_LOGGING_CATEGORY everywhere.
Fixes: QTBUG-127975
Change-Id: I9174dab21bd597c862e569e170161782cc108ece
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following the rewrite of the permissions API, transient
(a.k.a non-persistent) permissions still passed through
the persistent store sometimes, but were filtered out when
using user-facing APIs. Unfortunately, thisstill presented some
edge cases in the AskEveryTime permission policy mode.
This change modifies the PermissionManagerQt class to store
a second set of permissions, and associate them with a
RenderFrameHost the way the Chromium API is designed to do
anyway. This way, a permission will be kept around for the
lifetime of a web page, and calling JavaScript APIs that
trigger checks for permission state will work properly
(e.g. navigator.mediaDevices.enumerateDevices).
The new store is regularly cleaned up to make sure expired
permissions are purged before they impact performance.
As a side effect, this change also introduces pre-granting
of non-persistent permissions, which was the biggest
omission in the permissions rewrite. In those cases,
the permissions will be temporarily stored inside the
persistent store, and moved to the transient one the next
time they're queried (and can thus be associated with
a RenderFrameHost).
This also fixes some extremely broken test cases that
relied on invalid web API.
Fixes: QTBUG-127951
Pick-to: 6.8
Change-Id: Ic084af7673ea0b255d98d94382e77323bb5e7ab0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
A Qt Quick API was implemented alongside the Widgets one, but it
seems the quicknanobrowser example was never updated to make use of it.
Pick-to: 6.7 6.8
Change-Id: I8ac996f2237a2673bdbbab85a8174fa166fdd5b1
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
In updateWidget,receivedBytes / m_timeAdded.elapsed() * 1000 may divide
by zero,if m_timeAdded.elapsed() returns 0, it will cause the denominator
in the division to be zero, which will trigger a warning or error, to fix this,
check the m_timeAdded.elapsed() is zero, if it is, you can set a default
value () or just set bytesPerSecond to 0 to avoid dividing by zero.
Pick-to: 6.8 6.7
Change-Id: Id73b287d44241f97271308f85c64d4830b944948
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
m_progressBar->setValue(qRound(100 * receivedBytes / totalBytes));
There is a potential risk of de-zeroing here, since
receivedBytes / totalBytes will trigger a runtime
error if totalBytes is zero. In addition, if totalBytes
is always greater than or equal to 0, then checking for
totalBytes >= 0 is actually redundant, since the concern
should be that totalBytes is not zero. To ensure the robustness
of the code, a check that totalBytes is zero should be added
to prevent divide-by-zero errors. By ensuring that totalBytes
is greater than zero, this improvement not only avoids the
risk of de-zeroing, but also ensures that the percentage
calculation of the progress bar is meaningful. At the same
time, for cases where totalBytes is 0 or unknown, the progress
bar is displayed as 0% and the format is "unknown size".
This is a safer way to handle the situation and is more
in line with the needs of the actual application.
Pick-to: 6.8 6.7
Change-Id: I7537243e375f336f5c68ef1cc6ec8ade8fa16e5c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
When switching from profile from OTR to non-OTR requires valid storage
name. If it not there, then display a warning message and and don't
switch to disk based behavior.
Fixes: QTBUG-126312
Pick-to: 6.7 6.8 6.2
Change-Id: Id689c8b280b4070b9ecbf11c6001685ac4ffd2f3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Use the macros \QC and \QD.
Change-Id: I58c6064916b2449a63b5389a9afe7b64f772e3c2
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
| |
'Qt Designer' has been renamed to 'Qt Widgets Designer'.
Pick-to: 6.8
Change-Id: Iebb09d61b0b600acee71a17e0cb80855e68ad0be
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Removes ambiguous conversion of string types.
Fixes: QTBUG-127544
Pick-to: 6.8
Change-Id: I53d444b641c4b5190c1e391d9df21ccd7076ef13
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit bd6e209152d042a08fc226a9e92ee1c04cf1954a.
The change broke backwards compatibility with 6.8, because
the relevant macros were introduced after the feature freeze,
and are thus not part of the 6.8 release. This revert fixes
the impeding backwards incompatibility whenever WebEngine
6.9 is released.
Change-Id: I4626c4fe2647a5eb2a0729696cb80db6a47569a7
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.8
Change-Id: If371441d9b0d93fbd7a3e3e37e4f3780ddb52eb0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Example takes precedence over build system file type.
According to QUIP-18 [1], all examples file should be
LicenseRef-Qt-Commercial OR BSD-3-Clause
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.8
Task-number: QTBUG-121787
Change-Id: Ifb33a2b284ef234648b50d2333e83f7015023405
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
Reviewed-by: Kaloyan Chehlarski <kaloyan.chehlarski@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit contains fixes for the issues found during the API review
of the new permissions API. In particular:
- All new enums are now scoped
- Replaced isTransient with its opposite, isPersistent
- Renamed Feature to PermissionType
- Made origin() return a non-const QUrl
- Renamed PersistentPermissionsPolicy members to be more concise
- Fixed a couple of bugs in the implementation
- Updated documentation
Change-Id: Idf84e1c9ba3ae803ef4686e1caa7f3e6c198c87d
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following fa4bd30caa079a3b1e5eac1bb4f17365f456b8f9
all usage of the Q_LOGGING_CATEGORY macro triggers a deprecation
warning, and may even block certain build configurations. This change
replaces all usages of the macro with Q_STATIC_LOGGING_CATEGORY instead,
since none of the logging categories in WebEngine are meant to
be exported to users.
Change-Id: Icdebb7a3a8c987db3f34945cd0311aee52667a88
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make this class accessible from QML
- Mark properties as FINAL
- Change fullVersionList to QVariantMap to support it in QML
- Access ProfileAdapter through QPointer instead of raw pointer to make
it safer
Pick-to: 6.8
Change-Id: Ib242059378aaf6fd2c5f176ba26ed6f94e2afd76
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Amends 8e22839aa0
Task-number: QTBUG-126403
Pick-to: 6.7 6.8
Change-Id: I1560e5af29d2e94657a83e98bb649729b4a67cd2
Reviewed-by: Lucie Gerard <lucie.gerard@qt.io>
|