| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Pick-to: 6.10
Change-Id: I9615f0a095843fdf295e454a93476cf349f7fc76
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.10
Change-Id: Id2d09604201b2c007c76328f92bb4e0c0d802cae
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Neither QtWebEngine nor QtPDF can currently be compiled with MinGW.
Fixes: QTBUG-135100
Pick-to: 6.10 6.9 6.8
Change-Id: I93d5bcdd80d91cf0c2ef5e9e334d9f6be439ea83
Reviewed-by: Moss Heim <moss.heim@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
The version checks were already wrong, because we also need to support
building 6.11 on top of 6.8, assuming 6.11 is the next LTS. Instead of
fixing them, this commit removes them entirely, to avoid future
submodule update breakage. The explanatory comments have been amended to
correctly reflect when the workaround macros should actually be removed.
Change-Id: Iff894be9697a63eec67ddbe815617b1069e74e3b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since 6.10, QDoc is capable of generating links to the declaration in
the source code for each documented C++ API entity in their `Detailed
description`.
Add the required configuration to enable this feature for modules in
qtwebengine.
Pick-to: 6.10
Change-Id: Iab5a519f5d7bc15da0ca2d64dee374db72b245f1
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Correct the duplicated word "of" in the comment from "tree of of links" to
"tree of links". This typo could lead to confusion when reading the
documentation.
Pick-to: 6.9
Change-Id: Id19d02b1f2d52aa2b51f4d909ee73d57f26fb401
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Compile QtPdf on gcc-9 suse nodes.
Change-Id: I1f237f3dd404ec611006dc73b417d2bcea3bc1be
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Small clean up of gn integration patches.
Pick-to: 6.9
Change-Id: I27c8806cf29d2b74541ed2bc523871acb1b5ec0f
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PdfStyle.qml:
(qdoc) warning: Unknown base 'QtObject' for QML type 'PdfStyle'
Fixed by introducing a doc dependency to `qtqml`.
qwebenginenewwindowrequest.cpp:
(qdoc) warning: Invalid QML property type: QUrl
(qdoc) warning: Invalid QML property type: QRect
Replaced with QML types (url, rect) instead.
qwebenginewebauthuxrequest.cpp:
(qdoc) warning: Can't link to 'WebEngineWebAuthUxRequest.WebAuthUxState.CollectPin'
(qdoc) warning: Can't link to 'WebEngineWebAuthPinRequest::reason'
Pick-to: 6.9
Change-Id: I313dddba6a374e65c23d371437d0fb148374bd2c
Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do not require some features as they are not used
anyway by QtPdf otherwise they will require
extra libs installed on system to compile
compared to QtWebEngine. Moreover, some features
fire pkg-config and report errors when it fails.
We explicitly use AGG renderer for pdfium instead of skia,
this allows further drop of required dependencies.
For glibc check we can drop as we check for specific
version due to sand-boxing in qtwebengine.
Make build error and warnings more compact.
Works with static Qt builds now.
Fixes: QTBUG-127109
Pick-to: 6.9 6.8
Change-Id: Ic1fe7fb460481f9ae301a33bd44d0e5c3a6815c2
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Till now we used chromium defined toolchains
form build/toolchian/win, however these toolchains
use setup scripts focuses on dep tools integration.
Moreover they define also clang-cl toolchains which
later can be unwillingly used during compilation.
This changes clean up the msvc setup and uses for
native windows build toolchains defines by us.
Note that in follow up cleanup patches the introduced
msvc toolchain will not be generated in build dir.
Task-number: QTBUG-129970
Pick-to: 6.9
Change-Id: Ib84ed1f6ed5e2f39f5609d4773401d8ba83d79a4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During chromium part build we do generate some mocs
which can include headers synced by syncqt.
Chromium part is built before linking the WebEngineCore
and it can happen than syncqt was not executed yet
as there was not direct dependency on sync headers task,
only WebEngineCore target had this dependency.
Add missing direct dependency.
Pick-to: 6.9 6.8
Change-Id: I16a29764805cdfcf32776c9f1cb8318704164b93
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.9
Change-Id: Iad9c5c12c2bb69803627df73760daf6b7d4841bd
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In 130-base udev is not any longer loaded during runtime
and it is required as a optional build dependency:
https://chromium-review.googlesource.com/c/chromium/src/+/5738848
Add libudev pkg config check, this fixes RHEL-8 as it does not
have libudev package and therefore fixes gn configure issue.
Pick-to: 6.9
Task-number: QTBUG-132331
Change-Id: I64d481be562ee756c0444d29cf02d6c07fa4c76d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Moss Heim <moss.heim@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let's use is_qtpdf only when configuring qtpdf,
is_qtwebenigne should be still set in case
of qtpdf build to keep things simple.
The main reason for introducing this flag is
to keep easy track what changes are
done to gn configs jsut to have qtpdf builds.
Pick-to: 6.9
Change-Id: Ib0d36f8921c0502b00dac1b726543ba79dbca76b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The thread that calls QQuickPixmapReader::processJob() pulls out
the QPdfFile pointer, passes it to readImage() and expects that it
will not become a dangling pointer while readImage() is busy.
So it needs to call moveToThread() to "pull" the affinity to itself;
and that's only possible if it is set to null in the same thread
that initially has affinity.
Task-number: QTBUG-128875
Change-Id: Id54803783f353631f97c7676c90d5b0fbe09f4eb
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Importing headers with relative paths going out
of source component is evil.
Remove web_engine_logging.h header as it is referred
from the code base, but build system has no clue about it
as it is specified as include with relative path.
Moreover, it introduces weird implicit dependency of
components like qtpdf on qtwebenginecore.
Add required macro to private globals.
Note for qtpdf it is unnecessary as we do not support
compiling qtpdf against latest lts, however our release
infra requires it.
This commit amends d11709f18d692f4a3431999e90dddf0d7cdf15df.
Task-number: QTBUG-127975
Change-Id: I89163a29db4e601cfb607928f796343ba522037b
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
| |
Silence "note: No relevant classes found. No output generated."
Pick-to: 6.8
Change-Id: I27891753f3bb744d7aa7e4262683b3a20a3f9cdd
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Change-Id: If920f024c9f8fe18a9f22fa97b8fb5564dfa3b61
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
Don't process garbage data if the device has less than 6 bytes.
Change-Id: I2c44d869b109ea6e004b038f45dfc305da5aba10
Pick-to: 6.8
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a second attempt at getting rid of the deprecation warnings
caused by the new logging category macros in 6.9. These cause build
failures on warnings-as-errors configurations, and need to be fixed
properly without affecting backwards compatibility.
The change introduces a new Q_WEBENGINE_LOGGING_CATEGORY macro,
intended to be used across the WebEngine sources. The macro is
not exported to users, so the QtPdf example that declares its
own logging category uses an #ifdef instead.
The new macro is placed in its own header inside src/core/,
and is intended to be removed whenever the next LTS release
allows us to break compatibility with 6.8, and just directly
use Q_STATIC_LOGGING_CATEGORY everywhere.
Fixes: QTBUG-127975
Change-Id: I9174dab21bd597c862e569e170161782cc108ece
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We do not use print dialog and it seems 'use_cups' is
anyway overridden on linux in config setup to 'false'.
Therefore make sure it stays 'false' also for 'qtpdf'.
In case cups is needed at some point we should switch
from 'cups-config' (wrapped by cups_config_helper.py)
to 'pkg-config' during gn run as the
use of former one is deprecated.
Pick-to: 6.8
Task-number: QTBUG-120248
Fixes: QTBUG-122407
Change-Id: I150a0b30f4f57fe0f4fe92fe8760eaebe4136bd8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This commit organizes the articles, so they:
- have a reasonable tree structure
- can be navigated through the topic tree in the Qt Creator help viewer
Task-number: QTBUG-127147
Change-Id: I3002ff3b0243e718ce56c4fb0017781ece2b7c7b
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The build system doesn't know about all the Chromium dependencies to
automatically add them to the generated SBOM, so mark those modules as
containing incomplete information regarding 3rd party dependencies.
Pick-to: 6.8
Task-number: QTBUG-122899
Change-Id: I9475e02a0633e0f6eaa86e1d7d2335e949c7dc97
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit bd6e209152d042a08fc226a9e92ee1c04cf1954a.
The change broke backwards compatibility with 6.8, because
the relevant macros were introduced after the feature freeze,
and are thus not part of the 6.8 release. This revert fixes
the impeding backwards incompatibility whenever WebEngine
6.9 is released.
Change-Id: I4626c4fe2647a5eb2a0729696cb80db6a47569a7
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following fa4bd30caa079a3b1e5eac1bb4f17365f456b8f9
all usage of the Q_LOGGING_CATEGORY macro triggers a deprecation
warning, and may even block certain build configurations. This change
replaces all usages of the macro with Q_STATIC_LOGGING_CATEGORY instead,
since none of the logging categories in WebEngine are meant to
be exported to users.
Change-Id: Icdebb7a3a8c987db3f34945cd0311aee52667a88
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to QUIP-18 [1], all documentation files should be
LicenseRef-Qt-Commercial OR GFDL-1.3-no-invariants-only
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: Ibf7b2738d62e5f2075183d2f0376774583595a55
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
| |
The behavior that argument was enabling is the default one now.
Task-number: QTBUG-90492
Change-Id: I95d4ad82c587a4e0a81320bf12d8b610f1c1ae7d
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PdfPageView QML Type documentation contains a code snippet. The code
snippet should demonstrate how to use the PdfPageView QML type, however it uses the PdfMultiPageView QML type instead. This fix creates a new
code snippet that implements the PdfPageView QML type. This snippet
replaces the incorrect snippet that was used previously.
Fixes: QTBUG-123536
Pick-to: 6.7
Change-Id: I319b4d86133d7dc41664229110a6c13ed46b7e80
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If QPdfLink stored polygons instead of rects, it would make sense to
transform each point using QPdfDocumentPrivate::mapPageToView();
but the quadpoints (polygons) in the test.pdf from QTBUG-100630 happen
to describe rectangles. This patch successfully does the transform so
that they line up with the link text. It doesn't do much good since the
links in that PDF are invalid anyway, but presumably links using
quadpoints occur in the real world sometimes.
Pick-to: 6.7
Task-number: QTBUG-100630
Change-Id: I0cb151dbb30ca73c8f9ed2bcd29508ced05de064
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use FPDF_PageToDevice() rather than subtracting from page height,
in all the remaining places where we were doing that.
Also use FPDF_DeviceToPage() to convert coordinates coming from
the view, for hit-testing links and for selecting ranges of text.
Mark the private utility functions that we're modifying const
while we're at it.
Pick-to: 6.5 6.6 6.7
Task-number: QTBUG-100630
Fixes: QTBUG-106565
Change-Id: Ide4f73b80888a0e08381c6e4995f69ebeaa2d12f
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a drive-by, remove unneeded includes.
QPdfDocumentPrivate::convertPageRect() will be useful for fixing
related bugs. If PDF files can contain arbitrary transforms, and
"page coordinates" returned from pdfium functions are not already
converted, then it's never ok to just subtract from page height to
invert the y's.
Pick-to: 6.5 6.6 6.7
Fixes: QTBUG-120764
Change-Id: Iffce528c0c5e66c499e7147078b7b8718f7610ce
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a PDF-viewing application is unceremoniously exited while
QQuickPixmapReader::processJobs() still has PDF rendering jobs
queued up, it could be that the shared QPdfDocument instance
is deleted just as QPdfIOHandler::read() starts the rendering.
Use a QPointer to avoid that.
Fixes: QTBUG-121502
Pick-to: 6.5 6.6 6.7
Change-Id: I5d0674ca77ab5015b710df49b3842064e65d4adc
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This example exists to show a simpler viewer using PdfScrollablePageView
rather than PdfMultiPageView. Most users will probably prefer the latter,
so we don't highlight this one.
Pick-to: 6.7
Task-number: QTBUG-81560
Change-Id: Ia601b8c8ec0cb9002aa118917720a37b4f8095a5
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-117983
Change-Id: I11cb0bbc54f0679d99e64ae737655f91a93c568a
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-117983
Change-Id: Ic7a1ea3e9a9015dd797d4beb86fed74ef0e5c976
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When executing 'ninja docs' documentation is generated locally with
code attributions for qtwebengine and qtpdf, however it is missing on
doc.qt.io in case of qtpdf.
Make 'ninja prepare_docs' target to already generate pdf_attributions,
hopefully it fixes the issue as it is unknown how those docs are
generated in the end, moreover this is the only difference between
qtwebengine and qpdf doc target setup.
This amends 98c84d8d7a4ef4a308b1a75f90ff075135995c60
Fixes: QTBUG-120663
Pick-up: 6.7 6.6 6.5
Change-Id: Id1b371209ead987460fabb53c3bc35070dbedb35
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.7 6.6
Change-Id: I68e46ec382c4c63c106c545cf6815777954a6afc
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A crash was possible if there are no search results and the user
presses the up/down buttons alongside the search field on the toolbar.
That was easily fixed (in a previous patch); but actually those buttons
should be disabled if there are no results to navigate. To do that, we
need a notifying property rather than depending on the invokable
QAIM::rowCount(). Follow the usual pattern for a one-dimensional model:
add a `count` property in the subclass (as in XmlListModel,
FolderListModel, CalendarModel, and a few others).
Task-number: QTBUG-119776
Change-Id: I51c75b58f3a440c1c470794518a572b384376ea7
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTBUG-119776
Pick-to: 6.2 6.5 6.6 6.7
Change-Id: Id7addc15c15b78451d7f8b989335d12976426a30
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I8eea99a472cc597ff9864b570c90b28b79b3751e
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
| |
Change-Id: I1131b2873f82d954ca47bf90bc82200d5f4cd751
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-115044
Pick-to: 6.5 6.6
Change-Id: I83314f3b7955e1ef9c857bcc96c07f6f90b2f875
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
third_party zlib got pulled into build and we need also
use_system_zlib flag set accordingly.
Pick-to: 6.6 6.5
Task-number: QTBUG-116595
Change-Id: Iee4c91ec240512e23fe7ab612658320b0537920c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTBUG-119536
Pick-to: 6.5 6.6
Change-Id: I31028e19c2d376133f0fcd6c06ecc295163f1747
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add builds for android on windows platform. These
are required by qt release scripts to create armv7 targets
on windows.
Note new 'is_mingw' setting for toolchainis. This required
as andorid on windows build use mingw toolchain as a
host toolchian. Main gn_arg argument 'is_mingw' is used
only for target/default toolchian, in this case gn drops
toolchian_args. However toolchain_args are evaluated in
case of secondary/host toolchain.
Override v8 snapshot toolchain to avoid pulling windows
(msvc or clang) toolchains and creating yet another set of
toolchain targets.
Task-number: QTBUG-83459
Change-Id: I927872d69e363277b9f90c3adda28518d6b6bb13
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
src/pdfwidgets/qpdfpageselector.cpp:
* warning: Cannot find 'QPdfPageSelector::currentPageIndex'
specified with '\property' in any header file
src/core/doc/src/qtwebengine-deploying.qdoc:
* warning: Unknown command '\maocs'
Mark documentation modules free of warnings.
Pick-to: 6.6
Change-Id: Icbdf9622501b1fc4911f58682ffd2146efc36c1f
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
|
| |
Policy in qtwebengine is to use a separate d-pointer to avoid tying
the module build to a particular upstream Qt release.
Pick-to: 6.6 6.6.0
Change-Id: I0be241ee379663721225484cda22d952942a95fd
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This is a prerequisite for using QT_PDF_REMOVED_SINCE.
Pick-to: 6.6
Change-Id: I46adece3ba1ff1a4c95218a1bc731dea05afc1f3
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
|
|
|
|
|
|
|
|
| |
Amends b8419577eb99c158
Pick-to: 6.6
Change-Id: Ie60b418be63699cf1ff2baec5d867ccd85536f2b
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
|