Skip to content

feat: Shared knowledge problem related permission constant #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

feat: Shared knowledge problem related permission constant #3811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/common/constants/permission_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1175,6 +1175,10 @@ class PermissionConstants(Enum):
group=Group.SYSTEM_KNOWLEDGE_PROBLEM, operate=Operate.DELETE, role_list=[RoleConstants.ADMIN],
parent_group=[SystemGroup.SHARED_KNOWLEDGE]
)
SHARED_KNOWLEDGE_PROBLEM_RELATE = Permission(
group=Group.SYSTEM_KNOWLEDGE_PROBLEM, operate=Operate.RELATE, role_list=[RoleConstants.ADMIN],
parent_group=[SystemGroup.SHARED_KNOWLEDGE]
)
SHARED_KNOWLEDGE_HIT_TEST = Permission(
group=Group.SYSTEM_KNOWLEDGE_HIT_TEST, operate=Operate.READ, role_list=[RoleConstants.ADMIN],
parent_group=[SystemGroup.SHARED_KNOWLEDGE]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet looks mostly clear and follows a consistent structure, but there are no obvious irregularities or errors. However, here are a few suggestions for improvement:

  1. Consistent Indentation: Ensure that all elements under each Permission constant have consistent indentation to maintain readability.

  2. Variable Naming: The variable names are already in snake_case, which is generally a good practice for constants. If you're using a more explicit naming convention (e.g., PascalCase), consider adopting it consistently throughout the module.

  3. Comments: Adding comments can help clarify the purpose of this section if additional context was omitted. For example, what exactly does each permission represent?

  4. Duplicated Parent Groups: There are repeated mentions of SystemGroup.SHARED_KNOWLEDGE in both SHARED_KNOWLEDGE_PROBLEM and SHARED_KNOWLEDGE_HIT_TEST. This might be redundant unless there's intentional duplication intended.

Overall, the current implementation meets most best practices for declaring permissions within an enumeration.

Expand Down
Loading