Skip to content

Add struct field visualization to the editor message hierarchy tree visualization on the website #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

MohdMohsin97
Copy link
Contributor

No description provided.

@Keavon Keavon changed the title Fix Message Tree: Enforce Structure and Visibility Add struct field visualization to the editor message hierarchy tree visualization on the website Aug 2, 2025
@Keavon
Copy link
Member

Keavon commented Aug 2, 2025

Marking as draft while awaiting fixes for these erroneous outputs found with a regex search for ── \n (as mentioned on Discord):

capture capture

@Keavon Keavon marked this pull request as draft August 2, 2025 06:28
@MohdMohsin97 MohdMohsin97 marked this pull request as ready for review August 2, 2025 09:33
@MohdMohsin97 MohdMohsin97 marked this pull request as draft August 2, 2025 09:49
@MohdMohsin97 MohdMohsin97 marked this pull request as ready for review August 3, 2025 05:19
@Keavon
Copy link
Member

Keavon commented Aug 6, 2025

Requested changes as written in Discord, which I'm also copying here for reference:

  • In transform_message_handler.rs, we have an example of a tuple-style message enum variant which breaks the naming convention which should require struct-style variants. It doesn't look like this was caught by the node macro changes by throwing an error. Could you please look into this?

  • The Message::Frontend variant has a child for FrontendMessage which is working correctly, and another child that just says `` which needs to be filtered out.

    capture

@Keavon Keavon marked this pull request as draft August 6, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants