Skip to content

Add implicit NumPy conversion for dpctl.tensor.usm_ndarray types #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

icfaust
Copy link

@icfaust icfaust commented Aug 5, 2025

The functionality introduced in #1964 can be better optimized by moving code from _copy_utils to the usm_ndarray itself. This will make seamless integration into other larger codebases like scikit-learn, where use of asarray is common. It attempts to solve #2129

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@icfaust icfaust changed the title Add implicit NumPy conversion for dpctl.tensor.usm_array types Add implicit NumPy conversion for dpctl.tensor.usm_ndarray types Aug 5, 2025
@coveralls
Copy link
Collaborator

coveralls commented Aug 5, 2025

Coverage Status

coverage: 85.903% (+0.03%) from 85.878%
when pulling 1b8b30b on icfaust:dev/array_fix
into 3381d14 on IntelPython:master.

@icfaust icfaust marked this pull request as ready for review August 5, 2025 11:36
@icfaust
Copy link
Author

icfaust commented Aug 5, 2025

@ndgrigorian I am unable to check the jenkins CI checks. Is there any way someone from your team can help me?

@ndgrigorian
Copy link
Collaborator

@ndgrigorian I am unable to check the jenkins CI checks. Is there any way someone from your team can help me?

I can help with that, but there are still concerns with this PR that need to be addressed, some of which I mentioned in the issue

If this PR were modified to accept an environment variable to permit implicit conversion, that would be acceptable, but implicit conversion under all circumstances should not be allowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants