Added Discord link #41
Conversation
Changes made: Added Discord link in the header, as well as at the bottom
index.html
Outdated
| <h5><a href="https://learnteachcode.org/slack" target="_blank" rel="noopener">Join our Slack!</a> | <p> | ||
| <strong><a href="https://discord.gg/zSEyPCsFWD" target="_blank" rel="noopener">Join our Discord!</a></strong> | ||
| </p> | <a href="https://learnteachcode.org/code-coffee-compendium" target="_blank" rel="noopener">Resources</a> | <a href="./code-of-conduct.html">Code of Conduct</a></h5> |
There was a problem hiding this comment.
I think it's invalid HTML to have a
tag in an heading tag so let's just remove that extra tag
| </p> | ||
| <p> | ||
| <strong>Want to sponsor us?</strong> We're always on the lookout for more meeting spaces. Let us know if you have any suggestions or would like to sponsor us at your office! | ||
| </p> | ||
| </footer> | ||
|
|
||
| <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js" | ||
| s <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js" |
There was a problem hiding this comment.
a stray "s" appears! let's remove that before merging
| <h5><a href="https://learnteachcode.org/slack" target="_blank" rel="noopener">Join our Slack!</a> | <p> | ||
| <strong><a href="https://discord.gg/zSEyPCsFWD" target="_blank" rel="noopener">Join our Discord!</a></strong> | ||
| </p> | <a href="https://learnteachcode.org/code-coffee-compendium" target="_blank" rel="noopener">Resources</a> | <a href="./code-of-conduct.html">Code of Conduct</a></h5> | ||
| <h5><a href="https://learnteachcode.org/slack" target="_blank" rel="noopener">Join our Slack!</a> | |
There was a problem hiding this comment.
I can suggest a solution with javascript, as the template is same and just the links change, we can just make an object which contains the href links along with the title to display and just render it through.
There was a problem hiding this comment.
Thanks for the suggestion @anarchymonkey ! We're due for a total site overhaul anyhow so I'm going to leave it as is for now and later if we pick a blogging template (maybe Jekyll since it works well with GitHub Pages already, or something newer/trendier perhaps) it'll have support for templating via the static site generator :) and that way we won't have to run any client-side code to do templating which would be lovely
|
Closing this since Austin's PR also adds the Discord link and a couple other updates rolled into one. Sorry for losing track of this PR for so long! I appreciate the update :) |
Changes made: Added Discord link in the header, as well as at the bottom