-
Notifications
You must be signed in to change notification settings - Fork 113
Update bench.yml #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bench.yml #973
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the GitHub Actions workflow configuration for benchmarking to add an additional authorized user and reformats the conditional logic. The change allows both 'sbryngelson' and 'wilfonba' users to trigger benchmark runs on pull requests.
Key Changes
- Added 'wilfonba' as an authorized user who can trigger benchmarks via pull requests
- Reformatted the conditional logic from multi-line to single-line format
(github.event_name == 'pull_request_review' && github.event.review.state == 'approved') || | ||
(github.event_name == 'pull_request' && github.event.pull_request.user.login == 'sbryngelson') | ||
) }} | ||
if: ${{ github.repository=='MFlowCode/MFC' && needs.file-changes.outputs.checkall=='true' && ((github.event_name=='pull_request_review' && github.event.review.state=='approved') || (github.event_name=='pull_request' && (github.event.pull_request.user.login=='sbryngelson' || github.event.pull_request.user.login=='wilfonba'))) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This complex conditional logic should be split across multiple lines for better readability and maintainability. The original multi-line format was more readable than this single long line.
Copilot uses AI. Check for mistakes.
PR Code Suggestions ✨Explore these optional code suggestions:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
=======================================
Coverage 43.67% 43.67%
=======================================
Files 70 70
Lines 19818 19818
Branches 2473 2473
=======================================
Hits 8655 8655
Misses 9644 9644
Partials 1519 1519 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
User description
add bench for benchmarking
PR Type
Enhancement
Description
Expand benchmark workflow trigger conditions
Add 'wilfonba' user to authorized PR submitters
Simplify conditional formatting in GitHub Actions
Diagram Walkthrough
File Walkthrough
bench.yml
Expand benchmark workflow user authorization
.github/workflows/bench.yml