Skip to content

Docker: Use GreedySlotSelector in Hub and Standalone #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Aug 1, 2025

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Try to evaluate for fixing intermittent issue

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement


Description

  • Set GreedySlotSelector as default slot selector for Docker containers

  • Update documentation to reflect new default configuration

  • Add Kubernetes tolerations support for autoscaling patch jobs


Diagram Walkthrough

flowchart LR
  A["Docker Base Image"] --> B["SE_DISTRIBUTOR_SLOT_SELECTOR"]
  B --> C["GreedySlotSelector Default"]
  D["Documentation"] --> E["Updated Default Values"]
  F["Kubernetes Charts"] --> G["Added Tolerations Support"]
Loading

File Walkthrough

Relevant files
Configuration changes
Dockerfile
Set GreedySlotSelector as default slot selector                   

Base/Dockerfile

  • Added SE_DISTRIBUTOR_SLOT_SELECTOR environment variable with
    GreedySlotSelector as default value
+1/-0     
values.yaml
Add tolerations field to patch job                                             

charts/selenium-grid/values.yaml

  • Added tolerations field with empty list default for patch job
    configuration
+2/-0     
value.yaml
Set GreedySlotSelector as default value                                   

scripts/generate_list_env_vars/value.yaml

  • Changed SE_DISTRIBUTOR_SLOT_SELECTOR default from empty string to
    GreedySlotSelector class name
+1/-1     
Documentation
ENV_VARIABLES.md
Update slot selector documentation with defaults                 

ENV_VARIABLES.md

  • Updated SE_DISTRIBUTOR_SLOT_SELECTOR documentation with new default
    value
  • Added instructions for switching back to DefaultSlotSelector
+1/-1     
description.yaml
Update slot selector description with switch info               

scripts/generate_list_env_vars/description.yaml

  • Updated SE_DISTRIBUTOR_SLOT_SELECTOR description to include
    DefaultSlotSelector switch instructions
+2/-1     
Enhancement
CONFIGURATION.md
Add tolerations support for patch jobs                                     

charts/selenium-grid/CONFIGURATION.md

  • Added tolerations configuration option for autoscaling patch job
+1/-0     

Copy link
Contributor

qodo-merge-pro bot commented Aug 1, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Configuration Change

The default slot selector is being changed from DefaultSlotSelector to GreedySlotSelector. This could impact existing deployments and session distribution behavior. Verify this change aligns with the intended fix for intermittent issues and won't cause regressions.

SE_DISTRIBUTOR_SLOT_SELECTOR="org.openqa.selenium.grid.distributor.selector.GreedySlotSelector" \
SE_OTEL_JAVA_GLOBAL_AUTOCONFIGURE_ENABLED="true" \
Missing Template

The tolerations field is added to values.yaml but there's no corresponding template file changes shown in the diff. Verify that the Kubernetes job template properly uses this tolerations configuration.

# -- Tolerations for the patch job
tolerations: []

Copy link
Contributor

qodo-merge-pro bot commented Aug 1, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@VietND96 VietND96 merged commit 2d4be06 into trunk Aug 1, 2025
28 checks passed
@VietND96 VietND96 deleted the container-slot-matcher branch August 1, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant