-
Notifications
You must be signed in to change notification settings - Fork 36
Add weakref-based AutoUnload class to allow instances to be garbage collected #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1f8c768
Add WeakAutoUnload class.
jsza 077d7f1
Change listeners.tick.Delay to inherit from WeakAutoUnload.
jsza ddb5f70
Change WeakAutoUnload to use WeakValueDictionary to store instances.
jsza bffda92
Don't automatically unload WeakAutoUnload instances with __del__.
jsza 0f4b45c
Add WeakAutoUnload to __all__.
jsza c25f0ab
Remove extra newline at end of file.
jsza e9676fe
Update WeakAutoUnload doc string.
jsza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with the triple underscore here? I don't think this follows any convention in Python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, thanks, it seems this should have been 2 underscores as per https://www.python.org/dev/peps/pep-0008/ (to avoid naming collisions for subclasses).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere we defined that we don't want to use super-private attributes. That's why we never use 2 underscores in SP. It seems like that point is missing in the wiki.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ayuto Those aren't super-private attributes, they're to avoid name collision in subclasses like @jsza said. Here's a good talk about it from Raymond Hettinger. Although, they can still be avoided and in this case I'm not really sure if it's needed at all.