test(react-query/useQueries): replace inline 'Promise' delays with 'sleep', and add 'expect' using 'toBeInTheDocument' #9466
+28
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leep', and add 'expect' using 'toBeInTheDocument'
|
View your CI Pipeline Execution ↗ for commit 49e4cae
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9466 +/- ##
===========================================
+ Coverage 45.30% 84.38% +39.07%
===========================================
Files 208 26 -182
Lines 8283 365 -7918
Branches 1869 107 -1762
===========================================
- Hits 3753 308 -3445
+ Misses 4085 48 -4037
+ Partials 445 9 -436 🚀 New features to boost your workflow:
|
…delays-with-sleep
manudeli
reviewed
Jul 19, 2025
Comment on lines
1236
to
1243
| queryFn: async () => { | ||
| if (id === 2) { | ||
| await sleep(10) | ||
| return Promise.reject(new Error('FAILURE')) | ||
| } | ||
| await sleep(10) | ||
| return Promise.resolve({ id, title: `Post ${id}` }) | ||
| }, |
There was a problem hiding this comment.
This is just a small thing I wanna make like this.
Suggested change
| queryFn: async () => { | |
| if (id === 2) { | |
| await sleep(10) | |
| return Promise.reject(new Error('FAILURE')) | |
| } | |
| await sleep(10) | |
| return Promise.resolve({ id, title: `Post ${id}` }) | |
| }, | |
| queryFn: () => sleep(10).then(() => { | |
| if(id === 2) throw new Error('FAILURE') | |
| return { id, title: `Post ${id}` } | |
| }), |
There was a problem hiding this comment.
I agree with you. I gonna reflect your suggestion. 👍
…ck properties of all observer case
manudeli
approved these changes
Jul 20, 2025
sukvvon
deleted the
test/react-query-useQueries-replace-Promise-delays-with-sleep
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.