Add Scripts helper classes #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
camillobruni
commented
Jul 31, 2025
camillobruni
commented
- Add ShellScripts and BrowserScripts helper classes
- Use temp array for scripts in both cases
- Directly add promise error handler for browser scripts
- Move runCode to the corresponding scripts class
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danleh
reviewed
Jul 31, 2025
danleh
approved these changes
Jul 31, 2025
| throw new Error("addWithURL not supported"); | ||
| } | ||
|
|
||
| addUtils() { |
There was a problem hiding this comment.
nit: if we anyways do this always, can't this be put into the ctor and remove this method?
| this.scripts = []; | ||
| } | ||
|
|
||
| run() { |
There was a problem hiding this comment.
Could we have a short comment what this is doing? IIUC, this is basically a builder pattern, and run doesn't actually run any scripts, but finishes assembling in a way that it can be later run by the driver.
So maybe also rename to assembleScripts and let the comment mention that this object is not supposed to be used afterwards.
There was a problem hiding this comment.
it does actually run the scripts. The moment we attach them to the DOM or call loadString we do evaluate the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.