Improve regression line rendering #87
Open
+46
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-motionmark-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vmiura
force-pushed
the
improve_regression_line_rendering
branch
3 times, most recently
from
b73a94d to
a600ad5
Compare
smfr
reviewed
Aug 4, 2025
| // Find the inflection point based on complexity | ||
| while (inflectionIndex < endIndex) { | ||
| const complexity = controllerSamples.getFieldInDatum(inflectionIndex + 1, Strings.json.complexity); | ||
| if (complexity < inflectionComplexity) |
There was a problem hiding this comment.
This presupposes that ramps are going downward; if we change that it breaks. Maybe we should just mark the complexity change frames in the data?
Is this the end of a set of frames with fixed complexity? If so, just check for a change in complexity. This and the above chunk could use a helper function that just finds the next frame which has a complexity change.
vmiura
force-pushed
the
improve_regression_line_rendering
branch
2 times, most recently
from
d6cfcac to
e580b94
Compare
Regressions on the time graph used a very rough 'percentage' calculation based on the inflection complexity and overall start and end complexity of a ramp. This can sometimes be significantly different from the actual sample data, since samples do not take a uniform amount of time. Improve this by finding the inflection complexity point in the sample data.
vmiura
force-pushed
the
improve_regression_line_rendering
branch
from
e580b94 to
f9a389f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressions on the time graph used a very rough 'percentage' calculation
based on the inflection complexity and overall start and end complexity of a
ramp. This can sometimes be significantly different from the actual sample
data, since samples do not take a uniform amount of time.
Improve this by finding the inflection complexity point in the sample data.
Graphs before (note, the very compressed regression line for the 1st ramp)
Graphs after
