Merge atom-angularjs #3
Conversation
|
@ProLoser |
| @@ -1,3 +1,4 @@ | |||
| .DS_Store | |||
| npm-debug.log | |||
| node_modules | |||
| .idea/ | |||
There was a problem hiding this comment.
So this is actually specific to your work environment (then again, so is .DS_Store). Instead of committing into this repo, you should use a global .gitignore
I would remove this line and the .DS_Store line and any others not relevant to this project (actually, I think the whole file might not be necessary in this case).
|
Alright I provided lots and lots of feedback for you to consider, but otherwise feel free to merge this yourself whenever you're comfortable with it. |
|
I'd also suggest trying out some of the stuff in this original version before you merge to see how you feel about it or how it works for you. |
|
I updated my pull request. I'm really glad you post lots feedback for my code. It's first time we work together. so I think we have to understand each other and discuss which direction the package choose. Feedback is always welcome. thank you. |
merged from atom-angularjs package
merged from atom-angularjs package
remove some of old snipptes. because when prefixes are duplicated, only last one works and prefixes started with special characters, such like `|`, `$`, doesn't work in Atom.
Merged from atom-angularjs package.