fix(material/chips): focus not moved on destroy #31653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some logic that moves focus if a chip is destroyed so that it doesn't go back to the `body`. The removal timing seems to have changed at some point which broke the focus restoration, because the element is blurred before it is destroyed. These changes make the logic a bit more robust by checking the key manager for the removed chip.
crisbeto
requested review from
andrewseguin and
ok7sai
and removed request for
a team
wagnermaciel
approved these changes
Aug 6, 2025
|
The changes were merged into the following branches: main, 20.1.x |
crisbeto
added a commit
that referenced
this pull request
Aug 6, 2025
We have some logic that moves focus if a chip is destroyed so that it doesn't go back to the `body`. The removal timing seems to have changed at some point which broke the focus restoration, because the element is blurred before it is destroyed. These changes make the logic a bit more robust by checking the key manager for the removed chip. (cherry picked from commit 4bf8ebf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some logic that moves focus if a chip is destroyed so that it doesn't go back to the
body. The removal timing seems to have changed at some point which broke the focus restoration, because the element is blurred before it is destroyed.These changes make the logic a bit more robust by checking the key manager for the removed chip.