Fix OTel Next.js guide #355
Conversation
| url: `https://${process.env.AXIOM_DOMAIN}/v1/traces`, | ||
| headers: { | ||
| Authorization: `Bearer ${process.env.API_TOKEN}`, | ||
| "X-Axiom-Dataset": `${process.env.DATASET_NAME}`, |
There was a problem hiding this comment.
would be nice to standardize the environment variables between the different guides (API_TOKEN is also just not very descriptive)
in https://axiom.co/docs/ai-engineering/quickstart we use AXIOM_DATASET and AXIOM_TOKEN
There was a problem hiding this comment.
Placeholders are standardised as API_TOKEN and DATASET_NAME. What you refer to are environment variable names which are not standardised. Please see this research for more details and the rationale behind this: https://www.notion.so/axiomhq/Standardise-placeholders-18bfc65a3019809eab60f67858e42ac4
But the placeholders in the AI engineering quickstart are wrong. Thanks for spotting that. I've just updated them.
I'm open to discussing different standards, but for now, I would keep everything API_TOKEN and DATASET_NAME so that we can easily change it in the future if required.
|
|
||
| Add the `API_TOKEN` and `DATASET_NAME` environment variables to your `.env` file. For example: | ||
| 1. Add the `AXIOM_DOMAIN`, `API_TOKEN`, and `DATASET_NAME` environment variables to your `.env` file. For example: |
| { | ||
| "compilerOptions": { | ||
| "target": "ES2017", |
There was a problem hiding this comment.
possible to go even newer? no worries if not
There was a problem hiding this comment.
@c-ehrlich This is what was generated in my testing. Should we go newer? If yes, what would you recommend? What are the possible issues of going higher?
Basis: https://watchlyhq.slack.com/archives/C03HV6C998A/p1751613195572309