Issue #7: add example for MethodLength #112
Conversation
|
please add expected.txt I confirm that there should be no violation, as update is not related MethodLength. |
|
@romani @rdiachenko check please |
| @@ -122,4 +122,21 @@ public void testMemberName() throws Exception { | |||
| testByConfig( | |||
| "MemberName/patchedline/defaultContextConfig.xml"); | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore("MethodLength should have a violation when method length" | |||
There was a problem hiding this comment.
please put "until ", it is much easier to see where are we have problems.
| public class Test { | ||
| private String name; | ||
|
|
||
| public void test() { // violation context, should be suppressed after patching |
There was a problem hiding this comment.
Test.java is always after patch.
should be suppressed after patching
we will see this in expected.txt, lets not duplicate information.
In Input files we keep comment on lines where violation is present without PatchFilter.
There was a problem hiding this comment.
please make it simple // violation to show clearly that is not related to any strategy in filter.
to avoid any other confusion we might have do // violation without filter to make it absolutely clear. If you agree lets update all Inputs (in separate issue).
| @@ -0,0 +1,7 @@ | |||
| public class Test { | |||
There was a problem hiding this comment.
contexttwo -> context/relevant/.. or contextNotRelevant/....
#7
Demonstration of the case, when violations should be thrown only before patching and should be suppressed after