fix: SMTP connection resource validation in Email
class destructor
#9648
+21
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the destructor was checking
$this->SMTPConnect !== null
to validate SMTP connections.However,
fclose()
creates closed resources that are notnull
, which led to unnecessary cleanup attempts on already-closed connections.When the
SMTPKeepAlive
option isfalse
(the default), thequit
command is called before the destructor is reached.Fixes #9647
Checklist: