Skip to content

feat: redesign diff view with horizontal layout and new tab options #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ThomasK33
Copy link
Member

Improved Diff View Layout and Configuration

This PR refactors the diff view functionality to provide more flexible layout options and better tab management:

  • Added a new layout option to replace the previous vertical_split boolean, supporting both "vertical" and "horizontal" layouts
  • Replaced open_in_current_tab with open_in_new_tab for more intuitive configuration
  • Removed redundant options auto_close_on_accept and show_diff_stats that were no longer used
  • Added proper type annotations for configuration options
  • Implemented improved window management when opening diffs in new tabs
  • Added terminal window preservation when opening diffs in new tabs
  • Improved window option handling to maintain consistent appearance across different layouts
  • Enhanced cleanup logic to properly handle both tab-based and window-based diff views
  • Updated tests to reflect the new configuration options

These changes make the diff view more customizable while simplifying the configuration interface. Users can now choose between vertical or horizontal layouts and easily open diffs in new tabs while maintaining access to the terminal.

@ThomasK33 ThomasK33 marked this pull request as ready for review August 7, 2025 10:29
Copy link
Member Author

ThomasK33 commented Aug 7, 2025

@ThomasK33 ThomasK33 linked an issue Aug 7, 2025 that may be closed by this pull request
@ThomasK33 ThomasK33 changed the base branch from thomask33/feat_add_Claude_Haiku_model_and_update_type_annotations to graphite-base/111 August 7, 2025 10:35
@ThomasK33 ThomasK33 force-pushed the thomask33/feat_redesign_diff_view_with_horizontal_layout_and_new_tab_options branch from 82aff2b to 9734f3f Compare August 7, 2025 10:36
@graphite-app graphite-app bot changed the base branch from graphite-base/111 to main August 7, 2025 10:36
@ThomasK33 ThomasK33 force-pushed the thomask33/feat_redesign_diff_view_with_horizontal_layout_and_new_tab_options branch 3 times, most recently from 0eece5d to 4ae7572 Compare August 7, 2025 19:41
Change-Id: Ia8df210bad3a05b7eddd92fafbbb4f8aa90e2704
Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33 ThomasK33 force-pushed the thomask33/feat_redesign_diff_view_with_horizontal_layout_and_new_tab_options branch from 4ae7572 to 0f7c9ba Compare August 8, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] config.diff_opts.open_in_current_tab doesn't work
1 participant