Skip to content

chore: disable pyroscope profiling by default #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ values which are defined [here](https://github.com/grafana/helm-charts/tree/main
| prometheus.serverFiles."prometheus.yml".scrape_configs | list | `[]` | |
| prometheus.testFramework.enabled | bool | `false` | |
| pyroscope.alloy.enabled | bool | `false` | |
| pyroscope.enabled | bool | `true` | |
| pyroscope.enabled | bool | `false` | |
| pyroscope.pyroscope.extraArgs."log.level" | string | `"info"` | |
| pyroscope.pyroscope.fullnameOverride | string | `"pyroscope"` | |
| pyroscope.pyroscope.persistence.enabled | bool | `true` | |
Expand Down
2 changes: 2 additions & 0 deletions coder-observability/templates/_collector-config.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ loki.write "loki" {
}
}

{{ if .Values.pyroscope.enabled }}
pyroscope.scrape "pods" {
targets = discovery.relabel.pod_pprof.output
forward_to = [pyroscope.write.pods.receiver]
Expand All @@ -216,6 +217,7 @@ pyroscope.write "pods" {
url = "http://{{ include "pyroscope.fullname" .Subcharts.pyroscope }}.{{ .Release.Namespace }}.{{ .Values.global.zone }}:{{ .Values.pyroscope.pyroscope.service.port }}"
}
}
{{ end }}

prometheus.scrape "pods" {
targets = discovery.relabel.pod_metrics.output
Expand Down
2 changes: 1 addition & 1 deletion coder-observability/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ prometheus:
enabled: false

pyroscope:
enabled: true
enabled: false
alloy:
enabled: false
pyroscope:
Expand Down
237 changes: 1 addition & 236 deletions compiled/resources.yaml

Large diffs are not rendered by default.