Skip to content

chore: switch pyroscope from 80 -> 4040 (to unprivledged) #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ values which are defined [here](https://github.com/grafana/helm-charts/tree/main
| grafana.datasources."datasources.yaml".datasources[0].timeout | string | `"{{ add $.Values.global.dashboards.queryTimeout 5 }}"` | |
| grafana.datasources."datasources.yaml".datasources[0].type | string | `"grafana-pyroscope-datasource"` | |
| grafana.datasources."datasources.yaml".datasources[0].uid | string | `"pyroscope"` | |
| grafana.datasources."datasources.yaml".datasources[0].url | string | `"http://pyroscope.{{ .Release.Namespace }}.{{ $.Values.global.zone }}"` | |
| grafana.datasources."datasources.yaml".datasources[0].url | string | `"http://pyroscope.{{ .Release.Namespace }}.{{ $.Values.global.zone }}:4040"` | |
| grafana.datasources."datasources.yaml".datasources[1].access | string | `"proxy"` | |
| grafana.datasources."datasources.yaml".datasources[1].editable | bool | `false` | |
| grafana.datasources."datasources.yaml".datasources[1].isDefault | bool | `true` | |
Expand Down Expand Up @@ -505,7 +505,7 @@ values which are defined [here](https://github.com/grafana/helm-charts/tree/main
| pyroscope.pyroscope.persistence.enabled | bool | `true` | |
| pyroscope.pyroscope.persistence.size | string | `"10Gi"` | |
| pyroscope.pyroscope.replicaCount | int | `1` | |
| pyroscope.pyroscope.service.port | int | `80` | |
| pyroscope.pyroscope.service.port | int | `4040` | |
| pyroscope.pyroscope.service.type | string | `"ClusterIP"` | |
| runbookViewer.image | string | `"dannyben/madness"` | |
| sqlExporter.image | string | `"burningalchemist/sql_exporter"` | |
Expand Down
2 changes: 1 addition & 1 deletion TESTING_KIND.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,5 +102,5 @@ To view the monitoring services, you can port forward their UI's.

- Grafana: `kubectl -n coder-observability port-forward svc/grafana 3000:80`
- Prometheus: `kubectl -n coder-observability port-forward svc/prometheus 3001:80`
- Pyroscope: `kubectl port-forward svc/pyroscope 3002:80`
- Pyroscope: `kubectl port-forward svc/pyroscope 3002:4040`
- Grafana Agent: `kubectl port-forward svc/grafana-agent 3003:80`
4 changes: 2 additions & 2 deletions coder-observability/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ grafana:
datasources:
- name: pyroscope
type: grafana-pyroscope-datasource
url: http://pyroscope.{{ .Release.Namespace }}.{{ $.Values.global.zone }}
url: http://pyroscope.{{ .Release.Namespace }}.{{ $.Values.global.zone }}:4040
isDefault: false
editable: false
access: proxy
Expand Down Expand Up @@ -538,7 +538,7 @@ pyroscope:
pyroscope:
fullnameOverride: pyroscope
service:
port: 80
port: 4040
type: ClusterIP
extraArgs:
log.level: info
Expand Down
4 changes: 2 additions & 2 deletions compiled/resources.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ data:
timeout: '905'
type: grafana-pyroscope-datasource
uid: pyroscope
url: http://pyroscope.coder-observability.svc
url: http://pyroscope.coder-observability.svc:4040
- access: proxy
editable: false
isDefault: true
Expand Down Expand Up @@ -11255,7 +11255,7 @@ spec:
app.kubernetes.io/name: grafana
app.kubernetes.io/instance: coder-observability
annotations:
checksum/config: 666fc9d25c33f33d23342eb8113dc2abcd9ba71cc245634e924f8397fb8d777b
checksum/config: 8143dd78a48b90e972a84c3078e9812a2536a4efff7ca13f404626d5eae08ab2
checksum/dashboards-json-config: 010b57348b6dd1f09007330c03d22a0570022534712646511cad39a9e3cb4bb7
checksum/sc-dashboard-provider-config: 01ba4719c80b6fe911b091a7c05124b64eeece964e09c058ef8f9805daca546b
kubectl.kubernetes.io/default-container: grafana
Expand Down