-
Notifications
You must be signed in to change notification settings - Fork 2
chore: add initial tests to repo #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@brettkolodny, can you please chunk this up so we can review? 2k+ LOC is a lot to look at in one shot and you'll get a more meaningful review if your diffs are smaller, e.g. ~500 LOC. |
It looks scarier than it is but the majority of those line changes are in the pnpm lock file which can essentially be ignored as it should mostly be from the new packages added in the package.json. I was having some pnpm issues after after a workspace update which could lead to big lockfile changes if I accidentally changed the pnpm version but I'm not seeing a change in the lockfile version so I think it's correct? |
That makes sense! Seems like a 1k+ line diff even discounting the lockfile so I would still recommend chunking it.
Looks like we're not pinning a |
Will do! Going to move this PR to draft now and separate it out into two different PRs |
First PR, I don't love having branches/PRs off of other branches that aren't main so I'll open up the next one after this one is submitted |
Closes #45
The initials tests in this PR cover basic UX and form rendering. There are some questions around how much really needs to be tested within this repo as testing everything would lead to a lot of duplicate with the tests that already exist within coder/coder.
Going forward I think the best ways to increase test coverage for this repo are: