Skip to content

fix: update HCP vault links to use current URL patterns #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Jul 31, 2025

Realized this was an issue while fixing how we're rendering GFM alerts on the Registry website.

Description

Basically, the URLs we're using right now are technically valid, but they were using the old URL pattern from before we created the coder/registry repo. The Registry website has logic to handle redirects for these, but we should avoid triggering it as it adds unnecessary entries to the user's browser history.

Changes made

  • Updated all Registry links in the HCP Vault alert to include coder as the namespace

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Realized this was an issue while updating how we're rendering GFM alerts on the Registry website.

Basically, the URLs we're using right now are technically valid, but they were using the old URL pattern from before we created the `coder/registry` repo in the first place. The Registry website has logic to handle redirects for these, but it was making the user's browser history messier than they needed to be.

## Changes made
- Updated all links in the HCP Vault alert to include `coder` as the namespace
@Parkreiner Parkreiner self-assigned this Jul 31, 2025
@matifali matifali added the version:patch Add to PRs requiring a patch version upgrade label Jul 31, 2025

This comment was marked as outdated.

@Parkreiner Parkreiner requested review from DevelopmentCats and removed request for DevelopmentCats July 31, 2025 19:25
@DevelopmentCats DevelopmentCats merged commit cf66809 into main Aug 1, 2025
4 checks passed
@DevelopmentCats DevelopmentCats deleted the mes/hcp-links branch August 1, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:patch Add to PRs requiring a patch version upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants