Skip to content

feat(zed): settings input and MCP servers example #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

matifali
Copy link
Member

This PR adds an optional settings input to the Zed module and updates the README with an example for configuring MCP servers.

Changes:

  • Add settings variable to modules/zed/main.tf
  • Add coder_script to write/merge ~/.config/zed/settings.json (respects $XDG_CONFIG_HOME and merges with existing settings if jq is available)
  • Update README with a settings example configuring MCP context servers and clarify default settings path

Test plan:

  • Syntax-only: bun test --filter zed fails in CI without Terraform; this change only adds inputs and a startup script. No behavior change to existing outputs.

Co-authored-by: Atif Ali 10648092+matifali@users.noreply.github.com

blink-so bot and others added 3 commits August 11, 2025 11:56
- Add optional settings input to write/merge ~/.config/zed/settings.json
- Document MCP servers example and settings.json path

Co-authored-by: Atif Ali <10648092+matifali@users.noreply.github.com>
Copy link
Contributor

blink-so bot commented Aug 11, 2025

Requesting review from @matifali. PR adds settings input to Zed module and README example for MCP servers. Thanks!

blink-so bot added 2 commits August 11, 2025 12:09
…use jsonencode)\n- update description per suggestion\n- README: link to Zed settings docs and jsonencode example
@matifali matifali added the version:minor Add to PRs requiring a minor version upgrade label Aug 11, 2025

This comment was marked as resolved.

@@ -50,7 +50,14 @@ variable "display_name" {
default = "Zed"
}

variable "settings" {
type = string
description = "Optional object of Zed settings to write to settings.json"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Optional object of Zed settings to write to settings.json"
description = "JSON encoded settings.json"

@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 17:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:minor Add to PRs requiring a minor version upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant