-
Notifications
You must be signed in to change notification settings - Fork 44
feat(zed): settings input and MCP servers example #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add optional settings input to write/merge ~/.config/zed/settings.json - Document MCP servers example and settings.json path Co-authored-by: Atif Ali <10648092+matifali@users.noreply.github.com>
Requesting review from @matifali. PR adds |
…use jsonencode)\n- update description per suggestion\n- README: link to Zed settings docs and jsonencode example
This comment was marked as resolved.
This comment was marked as resolved.
registry/coder/modules/zed/main.tf
Outdated
@@ -50,7 +50,14 @@ variable "display_name" { | |||
default = "Zed" | |||
} | |||
|
|||
variable "settings" { | |||
type = string | |||
description = "Optional object of Zed settings to write to settings.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Optional object of Zed settings to write to settings.json" | |
description = "JSON encoded settings.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
This PR adds an optional
settings
input to the Zed module and updates the README with an example for configuring MCP servers.Changes:
settings
variable to modules/zed/main.tfcoder_script
to write/merge~/.config/zed/settings.json
(respects$XDG_CONFIG_HOME
and merges with existing settings ifjq
is available)settings
example configuring MCP context servers and clarify default settings pathTest plan:
bun test --filter zed
fails in CI without Terraform; this change only adds inputs and a startup script. No behavior change to existing outputs.Co-authored-by: Atif Ali 10648092+matifali@users.noreply.github.com