-
Notifications
You must be signed in to change notification settings - Fork 45
HomePage Nav Donate Button #511
Conversation
Added Donate button to the homepage nagvigation bar pointing to the donate url
Thanks so much for opening your first PR here! |
This pull request is automatically deployed with Now. |
Deploy preview for coderplex ready! Built with commit 8bd5aa2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VickyAbishek Looks good!
Few suggestions:
- Please check the suggested changes above!
- Add a hover effect to the button as we have for other buttons on the site.
- Clicking on button should open donation page in a new tab!
One more suggestion: I think it is better to have Donate button color same as our theme color instead of red. |
I think the button height here is slightly too tall. It should be more wider on the sides / narrow horizontally |
@duttakapil Yeah, my suggested CSS changes above make it look good. |
Updatd donate button properties according other similiar button's properties in the website.
Hi all, |
Done. |
@VickyAbishek you don't need to create a new PR. You just push your code to the branch in your fork from which you sent the first PR, and it automatically updates |
🎉 🎉 🎊 Congrats on merging your first pull request! We here at coderplex.org are proud of you!. If you believe in our 📃 mission statement please ⭐ us. |
@all-contributors please add @VickyAbishek for code |
I've put up a pull request to add @VickyAbishek! 🎉 |
Added Donate button to the homepage nagvigation bar pointing to the donate url
Feature
What kind of change does this PR introduce
Added donate button
What is the current behavior
No Donate button
What is the new behavior
Added Donate button
Checklist for this PR
yarn lint
locally to format my code.yarn test
ran successfully.develop
branch.