Skip to content
This repository was archived by the owner on Mar 9, 2021. It is now read-only.

HomePage Nav Donate Button #511

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Conversation

VickyAbishek
Copy link
Contributor

Added Donate button to the homepage nagvigation bar pointing to the donate url

Feature

What kind of change does this PR introduce

Added donate button

What is the current behavior

No Donate button

What is the new behavior

Added Donate button

Checklist for this PR

  • I have read contributing guidelines.
  • I executed yarn lint locally to format my code.
  • I added revelant Tests to verify my code.
  • [] All tests yarn test ran successfully.
  • Pull request is towards develop branch.
  • I have tested responsiveness of the UI by checking on devices using ScreenFly
  • Added myself to contributors table
  • Documentation
  • Ready to be merged

Added Donate button to the homepage nagvigation bar pointing to the donate url
@welcome
Copy link

welcome bot commented Aug 10, 2019

Thanks so much for opening your first PR here!

@vercel
Copy link

vercel bot commented Aug 10, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@coderplex-bot
Copy link
Collaborator

coderplex-bot commented Aug 10, 2019

Deploy preview for coderplex ready!

Built with commit 8bd5aa2

https://deploy-preview-511--coderplex.netlify.com

Copy link
Contributor

@vinaypuppal vinaypuppal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VickyAbishek Looks good!
Few suggestions:

  1. Please check the suggested changes above!
  2. Add a hover effect to the button as we have for other buttons on the site.
  3. Clicking on button should open donation page in a new tab!

@KirankumarAmbati
Copy link
Contributor

One more suggestion:

I think it is better to have Donate button color same as our theme color instead of red.

@vinaypuppal
Copy link
Contributor

One more thing I forgot above, make the button look good on mobile. For example on mobile it should like this:
coderplex-xiplocrtgx now sh_(Nexus 5X)

@duttakapil
Copy link
Member

I think the button height here is slightly too tall. It should be more wider on the sides / narrow horizontally

@vinaypuppal
Copy link
Contributor

@duttakapil Yeah, my suggested CSS changes above make it look good.

Updatd donate button properties according other similiar button's properties in the website.
@VickyAbishek
Copy link
Contributor Author

Hi all,
Thank you all the for the suggestions. Created another pull request with the changes.
This is my first PR. Just bare me for the first few commits 😃, I will make sure I won't repeat the mistakes in the future commit.

@VickyAbishek
Copy link
Contributor Author

@VickyAbishek Looks good!
Few suggestions:

  1. Please check the suggested changes above!
  2. Add a hover effect to the button as we have for other buttons on the site.
  3. Clicking on button should open donation page in a new tab!

Done.

@duttakapil
Copy link
Member

@VickyAbishek you don't need to create a new PR. You just push your code to the branch in your fork from which you sent the first PR, and it automatically updates

@vinaypuppal vinaypuppal reopened this Aug 13, 2019
@vinaypuppal vinaypuppal merged commit 8543be4 into coderplex-org:develop Aug 13, 2019
@welcome
Copy link

welcome bot commented Aug 13, 2019

🎉 🎉 🎊 Congrats on merging your first pull request! We here at coderplex.org are proud of you!. If you believe in our 📃 mission statement please ⭐ us.

@vinaypuppal
Copy link
Contributor

@all-contributors please add @VickyAbishek for code

@allcontributors
Copy link
Contributor

@vinaypuppal

I've put up a pull request to add @VickyAbishek! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants