Skip to content
This repository was archived by the owner on Mar 9, 2021. It is now read-only.

Navbar is now responsive #60

Closed
wants to merge 1 commit into from
Closed

Navbar is now responsive #60

wants to merge 1 commit into from

Conversation

elevenpassin
Copy link
Collaborator

  • Transformed Header Component to be a class.
  • Made the Navbar responsive.

and also

  • Don't use padding in CSS, because it is not quite responsive.

@coderplex-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit f8cb13c

https://deploy-preview-60--coderplex.netlify.com

@M-ZubairAhmed
Copy link

@buoyantair amazing, i was procrastinating this for a while now. thanks for bring this up here in form of pr.

@elevenpassin
Copy link
Collaborator Author

elevenpassin commented Nov 1, 2017

@M-ZubairAhmed You were searching for Issues on facebook/react xD :D (that Chinese or some korean issue)
I also didn't get time to work on this since I said @duttakapil that I'd work on it,
Anyways, the menu at this point is not smooth, aka there's no transitions etc. and Also the menu is super deep in the tree and with flex box, things get messy in such cases. I'll try to tweak it next time.

@M-ZubairAhmed
Copy link

@buoyantair yes it does needs tweaking a bit, Also i was thinking we could move the hamburger on the left and logo in middle. Could you do that while you are at it.

@elevenpassin
Copy link
Collaborator Author

@M-ZubairAhmed Yeah will def do that when I tweak them the next time (probably this night idk)

@M-ZubairAhmed
Copy link

M-ZubairAhmed commented Nov 2, 2017

@buoyantair change of plans, we want to chuck the current menu and replace it with semantic-ui menu in web and in mobile we would like to have semantic-ui sidebar instead. We are on a time constraint here, can you implement it by today, if not its ok i will complete it off

Copy link

@M-ZubairAhmed M-ZubairAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it to semantic ui side bar in mobile

@elevenpassin
Copy link
Collaborator Author

@M-ZubairAhmed Im busy today, you might wanna take off if theres a time constraint

@vinaypuppal vinaypuppal removed their request for review November 2, 2017 11:09
@M-ZubairAhmed
Copy link

thank you @buoyantair

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants