Skip to content

Fixed seed command issue when selecting the existing stack #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: development
Choose a base branch
from

Conversation

sunil-lakshman
Copy link
Contributor

No description provided.

Copilot

This comment was marked as outdated.

@sunil-lakshman sunil-lakshman requested review from cs-raj and removed request for Copilot July 21, 2025 08:44
@shafeeqd959
Copy link
Contributor

@sunil-lakshman Make use of this change to fix the existing test cases

@shafeeqd959 shafeeqd959 requested a review from Copilot July 22, 2025 07:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with the seed command when selecting existing stacks. The main change updates the CLI seed dependency version from 1.11.3 to 1.11.4, which contains refactored code for better handling of existing stack selection, particularly for Compass app requirements.

Key changes:

  • Updates the @contentstack/cli-cm-seed dependency to version 1.11.4
  • Refactors seed logic to properly handle existing stack selection for Compass apps
  • Extracts Compass-specific validation logic into a dedicated helper module

Reviewed Changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/contentstack/package.json Updates main CLI version to 1.43.2 and seed dependency to ~1.11.4
packages/contentstack-seed/src/seed/index.ts Refactors seed logic with better error handling and extracted Compass validation
packages/contentstack-seed/src/seed/compassAppHelper.ts New helper module containing Compass app-specific validation logic
packages/contentstack-seed/package.json Bumps seed package version to 1.11.4
Multiple README files Updates version numbers and Node.js version in usage examples
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

packages/contentstack-seed/src/seed/compassAppHelper.ts:8

  • [nitpick] The token name is redundant with the description. Consider making it more descriptive like 'Compass App Management Token' or use a unique identifier.
    "name":"This is a compass app management token",

@shafeeqd959
Copy link
Contributor

@sunil-lakshman entire seed handler being revamped in this please do make sure we test all cases,

@shafeeqd959
Copy link
Contributor

@sunil-lakshman can you fix the current test cases and add them here

shafeeqd959
shafeeqd959 previously approved these changes Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants