Skip to content

Backporting Placeholder support for Cube Store (#420) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

ovr
Copy link
Member

@ovr ovr commented Apr 14, 2023

No description provided.

gamife and others added 2 commits April 14, 2023 16:03
Co-authored-by: gamife <gamife9886@gmail.com>
//left: box Subquery { .. },
//right: box Subquery { .. },
}
op: BinaryOperator::Plus,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo fmt))

@coveralls
Copy link

coveralls commented Apr 14, 2023

Pull Request Test Coverage Report for Build 4700225395

  • 26 of 31 (83.87%) changed or added relevant lines in 4 files are covered.
  • 49 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-6.8%) to 82.368%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 3 4 75.0%
tests/sqlparser_common.rs 16 17 94.12%
src/tokenizer.rs 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
src/parser.rs 1 84.51%
src/ast/mod.rs 2 70.48%
src/ast/query.rs 2 85.07%
tests/sqlparser_snowflake.rs 2 96.43%
tests/sqlparser_postgres.rs 8 97.06%
tests/sqlparser_common.rs 34 97.2%
Totals Coverage Status
Change from base Build 1513769481: -6.8%
Covered Lines: 5615
Relevant Lines: 6817

💛 - Coveralls

@ovr ovr merged commit 4388f67 into cube-main Apr 18, 2023
@ovr ovr deleted the cubestore-placeholder branch April 18, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants