Skip to content

feat: Extend ARRAY_AGG to support ORDER BY #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2023

Conversation

MazterQyou
Copy link
Member

This PR cherry-picks an upstream commit adding extended ARRAY_AGG syntax:
ARRAY_AGG([DISTINCT] <expr> [ORDER BY <expr>] [LIMIT <n>])
Related tests are included.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5027319512

  • 54 of 66 (81.82%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 89.495%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/mod.rs 1 2 50.0%
src/dialect/snowflake.rs 1 2 50.0%
src/ast/mod.rs 14 17 82.35%
src/parser.rs 27 34 79.41%
Totals Coverage Status
Change from base Build 3596717534: -0.05%
Covered Lines: 8877
Relevant Lines: 9919

💛 - Coveralls

@MazterQyou MazterQyou merged commit b3b4058 into cubesql-v0.16.0 May 19, 2023
@MazterQyou MazterQyou deleted the cubesql-array-agg-order branch May 19, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants