SEA: normalise column names in metadata queries #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
The Thrift backend returns a different schema in response to metadata queries (getting
catalogs,schemas,tables,columns) than the SEA backend. Here, we normalise the column names and types returned by SEA to align with those from Thrift.Column values will be addressed in #662.
We store the metadata columns, column mappings, etc. as state in the
ResultSetinstead of applying the changes once on the stored data because we may not get the data all at once, i.e., in case ofCloudFetchresults, we may have to get the data as multiple tables that need not be fetched at once. Thus, we store the columns and mappings, and apply it on the resultant of each fetch call.How is this tested?
Related Tickets & Documents
Design Document