Skip to content

catch illegal state exceptions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

catch illegal state exceptions #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f1e14e
catch illegal state exceptions
ramsundark5 May 25, 2019
d9e8153
more error catching
ramsundark5 May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions lib/src/main/java/com/otaliastudios/transcoder/transcode/VideoTrackTranscoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,25 @@ public void release() {
mEncoderInputSurfaceWrapper = null;
}
if (mDecoder != null) {
if (mDecoderStarted) mDecoder.stop();
mDecoder.release();
mDecoder = null;
try{
if (mDecoderStarted)
mDecoder.stop();
mDecoder.release();
mDecoder = null;
}catch(Exception e){
LOG.e("Error stopping decoder. Probably its already released "+e.getMessage());
}
}
if (mEncoder != null) {
if (mEncoderStarted) mEncoder.stop();
mEncoder.release();
mEncoder = null;
try{
if (mEncoderStarted)
mEncoder.stop();
mEncoder.release();
mEncoder = null;
}catch(Exception e){
LOG.e("Error stopping encoding. Probably its already released "+e.getMessage());
}

}
}

Expand Down Expand Up @@ -248,7 +259,12 @@ private boolean shouldRenderFrame() {

private int drainEncoder(long timeoutUs) {
if (mIsEncoderEOS) return DRAIN_STATE_NONE;
int result = mEncoder.dequeueOutputBuffer(mBufferInfo, timeoutUs);
int result = MediaCodec.INFO_TRY_AGAIN_LATER;
try{
result = mEncoder.dequeueOutputBuffer(mBufferInfo, timeoutUs);
}catch(Exception e){
LOG.e("Error dequeingoutputbuffer ", e);
}
switch (result) {
case MediaCodec.INFO_TRY_AGAIN_LATER:
return DRAIN_STATE_NONE;
Expand Down