DEV: explicit pnpm version in package.json and fix workflow #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
changed the title
tyb-talks
force-pushed
the
fix-package-json
branch
from
04015f6 to
2c2a3a9
Compare
nattsw
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed as the github action for setting pnpm needs an explicit version for reference, and some pathing changes to get the workflow working.
Tested with successful workflow run that raised a PR at #12.
While testing this, I discovered that GJS files will have incorrect lineNumber referencing (e.g.
ace:resizeevent) as we process those files first before we are able to run them through the parser (and by then, the lines differ from the source code). We'll need to figure out a different approach here for those.