-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix incorrect C# compiler option names and broken links in documentation #47734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
@copilot address the review comments |
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot There are several more warnings. Change the following anchors in multiple files:
- "advanced.md#mainentrypoint-or-startupobject" should now be "advanced.md#startupobject"
- "output.md#targettype" should now be "output.md#outputtype"
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
Fixed all the broken anchor links as requested. Updated all references from
Addressed the review comments by fixing all broken link warnings. Updated anchor references throughout the documentation to match the corrected property names. See commit 41fcab0. |
closing and reopening for a fresh build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for final review.
This PR addresses several inaccuracies in the C# compiler options documentation that were causing confusion for developers:
Issues Fixed
1. TargetType → OutputType
The documentation incorrectly referenced
TargetType
as an MSBuild property, but the actual property used in .csproj files isOutputType
. Updated all references throughout the documentation to use the correct property name that matches real-world usage:2. OutputAssembly Description Clarification
The
OutputAssembly
section was unclear about which MSBuild properties it actually corresponds to. Updated the description to clarify that it relates to the combination ofOutputPath
andAssemblyName
properties, with corrected examples:3. MainEntryPoint Property Removal
Removed references to the non-existent
MainEntryPoint
property from the advanced compiler options documentation. This property doesn't exist in MSBuild or Visual Studio, causing confusion when developers tried to use it.4. StartupObject Flexibility
Fixed the documentation for
StartupObject
to clarify that fully qualified class names are not always required - simple class names work when unambiguous, making the documentation more accurate and developer-friendly.5. Broken Link Fixes
Fixed broken anchor links that were created when updating property names. Multiple files had links pointing to the old
#targettype
anchor that needed to be updated to#outputtype
:Cross-Reference Updates
Updated all cross-references across multiple documentation files to ensure consistency, including:
These changes ensure the documentation accurately reflects the actual MSBuild property names and behavior that developers encounter when building .NET projects, while also maintaining working internal links.
Fixes #35950.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
Internal previews
Toggle expand/collapse